Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Optional .system(), part 3 #2422

Closed
wants to merge 2 commits into from

Conversation

Ratysz
Copy link
Contributor

@Ratysz Ratysz commented Jul 1, 2021

Objective

Solution

  • Introduce new prelude trait, ConfigurableSystem, that shorthands my_system.system().config(...) as my_system.config(...).
  • Expand configure_system_local test to also cover the new syntax.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jul 1, 2021
@mockersf mockersf added A-Core Common functionality for all bevy apps A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Jul 1, 2021
@cart
Copy link
Member

cart commented Jul 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 1, 2021
# Objective

- Continue work of #2398 and #2403.
- Make `.system()` syntax optional when using `.config()` API.

## Solution

- Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`.
- Expand `configure_system_local` test to also cover the new syntax.
@bors bors bot changed the title Optional .system(), part 3 [Merged by Bors] - Optional .system(), part 3 Jul 1, 2021
@bors bors bot closed this Jul 1, 2021
@Ratysz Ratysz deleted the optional_system_pt3 branch July 3, 2021 14:28
@Ratysz Ratysz added C-Usability A simple quality-of-life change that makes Bevy easier to use and removed A-ECS Entities, components, systems, and events labels Jul 4, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
# Objective

- Continue work of bevyengine#2398 and bevyengine#2403.
- Make `.system()` syntax optional when using `.config()` API.

## Solution

- Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`.
- Expand `configure_system_local` test to also cover the new syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants