diff --git a/Cargo.toml b/Cargo.toml index 15b2caa91ee63..348ca084662d6 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -71,7 +71,9 @@ ref_as_ptr = "warn" # see: https://github.com/bevyengine/bevy/pull/15375#issuecomment-2366966219 too_long_first_doc_paragraph = "allow" -std_instead_of_core = "warn" +# currently falsely fires on std::io, even tho core::io is unstable +# https://github.com/rust-lang/rust-clippy/issues/13158#issuecomment-4373196346 +std_instead_of_core = "allow" std_instead_of_alloc = "warn" alloc_instead_of_core = "warn" diff --git a/crates/bevy_animation/src/lib.rs b/crates/bevy_animation/src/lib.rs index b63ef7998dc62..defc52a7faf75 100644 --- a/crates/bevy_animation/src/lib.rs +++ b/crates/bevy_animation/src/lib.rs @@ -1756,7 +1756,7 @@ mod tests { AnimationTargetId::from_names(name_path.iter()), "{:?} {:?}", str_path, - &name_path + name_path ); } } diff --git a/crates/bevy_asset/src/reflect.rs b/crates/bevy_asset/src/reflect.rs index 5a36c43e4ec08..792aaddb6a2da 100644 --- a/crates/bevy_asset/src/reflect.rs +++ b/crates/bevy_asset/src/reflect.rs @@ -463,7 +463,7 @@ impl ReflectDeserializerProcessor for HandleDeserializeProcessor<'_> { else { return Err(D::Error::custom(format!( "Could not find asset type by name \"{}\" for UntypedHandle", - &typed_handle_reference.asset_type + typed_handle_reference.asset_type ))); }; let type_id = asset_type.type_id(); diff --git a/crates/bevy_ecs/src/query/mod.rs b/crates/bevy_ecs/src/query/mod.rs index 965191b7e4304..4f535925b9a4b 100644 --- a/crates/bevy_ecs/src/query/mod.rs +++ b/crates/bevy_ecs/src/query/mod.rs @@ -303,7 +303,7 @@ mod tests { sorted.sort(); assert!(expected.contains(&sorted), "the results of iter_combinations should contain this combination {:?}. Expected: {:?}, got: {:?}", - &sorted, &expected, &values); + sorted, expected, values); }); } diff --git a/crates/bevy_feathers/src/controls/text_input.rs b/crates/bevy_feathers/src/controls/text_input.rs index d937fb5021723..3b53dcb840234 100644 --- a/crates/bevy_feathers/src/controls/text_input.rs +++ b/crates/bevy_feathers/src/controls/text_input.rs @@ -95,9 +95,9 @@ impl FeathersTextInput { Node { flex_grow: { if props.visible_width.is_some() { - 0. + 0_f32 } else { - 1. + 1_f32 } } , } diff --git a/crates/bevy_math/src/bounding/bounded2d/mod.rs b/crates/bevy_math/src/bounding/bounded2d/mod.rs index 79def679f9ad3..00dcbc5181c3b 100644 --- a/crates/bevy_math/src/bounding/bounded2d/mod.rs +++ b/crates/bevy_math/src/bounding/bounded2d/mod.rs @@ -710,7 +710,7 @@ mod bounding_circle_tests { #[test] fn grow() { let a = BoundingCircle::new(Vec2::ONE, 5.); - let padded = a.grow(1.25); + let padded = a.grow(1.25_f32); assert!(ops::abs(padded.radius() - 6.25) < f32::EPSILON); assert!(padded.contains(&a)); assert!(!a.contains(&padded)); @@ -719,7 +719,7 @@ mod bounding_circle_tests { #[test] fn shrink() { let a = BoundingCircle::new(Vec2::ONE, 5.); - let shrunk = a.shrink(0.5); + let shrunk = a.shrink(0.5_f32); assert!(ops::abs(shrunk.radius() - 4.5) < f32::EPSILON); assert!(a.contains(&shrunk)); assert!(!shrunk.contains(&a)); @@ -728,7 +728,7 @@ mod bounding_circle_tests { #[test] fn scale_around_center() { let a = BoundingCircle::new(Vec2::ONE, 5.); - let scaled = a.scale_around_center(2.); + let scaled = a.scale_around_center(2_f32); assert!(ops::abs(scaled.radius() - 10.) < f32::EPSILON); assert!(!a.contains(&scaled)); assert!(scaled.contains(&a)); diff --git a/crates/bevy_math/src/bounding/bounded3d/mod.rs b/crates/bevy_math/src/bounding/bounded3d/mod.rs index cbfdb1d4f3909..fc4cd84f0b234 100644 --- a/crates/bevy_math/src/bounding/bounded3d/mod.rs +++ b/crates/bevy_math/src/bounding/bounded3d/mod.rs @@ -762,7 +762,7 @@ mod bounding_sphere_tests { #[test] fn grow() { let a = BoundingSphere::new(Vec3::ONE, 5.); - let padded = a.grow(1.25); + let padded = a.grow(1.25_f32); assert!(ops::abs(padded.radius() - 6.25) < f32::EPSILON); assert!(padded.contains(&a)); assert!(!a.contains(&padded)); @@ -771,7 +771,7 @@ mod bounding_sphere_tests { #[test] fn shrink() { let a = BoundingSphere::new(Vec3::ONE, 5.); - let shrunk = a.shrink(0.5); + let shrunk = a.shrink(0.5_f32); assert!(ops::abs(shrunk.radius() - 4.5) < f32::EPSILON); assert!(a.contains(&shrunk)); assert!(!shrunk.contains(&a)); @@ -780,7 +780,7 @@ mod bounding_sphere_tests { #[test] fn scale_around_center() { let a = BoundingSphere::new(Vec3::ONE, 5.); - let scaled = a.scale_around_center(2.); + let scaled = a.scale_around_center(2_f32); assert!(ops::abs(scaled.radius() - 10.) < f32::EPSILON); assert!(!a.contains(&scaled)); assert!(scaled.contains(&a)); diff --git a/crates/bevy_reflect/src/func/dynamic_function.rs b/crates/bevy_reflect/src/func/dynamic_function.rs index d9f881af33626..ecc91eb28575a 100644 --- a/crates/bevy_reflect/src/func/dynamic_function.rs +++ b/crates/bevy_reflect/src/func/dynamic_function.rs @@ -456,7 +456,7 @@ impl_type_path!((in bevy_reflect) DynamicFunction<'env>); /// [overloaded]: DynamicFunction::with_overload impl<'env> Debug for DynamicFunction<'env> { fn fmt(&self, f: &mut Formatter<'_>) -> core::fmt::Result { - write!(f, "DynamicFunction({:?})", &self.internal) + write!(f, "DynamicFunction({:?})", self.internal) } } diff --git a/crates/bevy_reflect/src/func/dynamic_function_mut.rs b/crates/bevy_reflect/src/func/dynamic_function_mut.rs index 6d8be5ac47b89..003be3f5abea9 100644 --- a/crates/bevy_reflect/src/func/dynamic_function_mut.rs +++ b/crates/bevy_reflect/src/func/dynamic_function_mut.rs @@ -346,7 +346,7 @@ impl<'env> DynamicFunctionMut<'env> { /// [overloaded]: DynamicFunctionMut::with_overload impl<'env> Debug for DynamicFunctionMut<'env> { fn fmt(&self, f: &mut Formatter<'_>) -> core::fmt::Result { - write!(f, "DynamicFunctionMut({:?})", &self.internal) + write!(f, "DynamicFunctionMut({:?})", self.internal) } } diff --git a/crates/bevy_render/src/render_resource/sparse_buffer_vec.rs b/crates/bevy_render/src/render_resource/sparse_buffer_vec.rs index cc73847a5b3ed..b8e27ca1ed550 100644 --- a/crates/bevy_render/src/render_resource/sparse_buffer_vec.rs +++ b/crates/bevy_render/src/render_resource/sparse_buffer_vec.rs @@ -243,7 +243,7 @@ fn update_sparse_buffers( command_encoder.begin_compute_pass(&ComputePassDescriptor { label: Some(&*format!( "sparse buffer update ({})", - &sparse_buffer_update_job.label + sparse_buffer_update_job.label )), timestamp_writes: None, }); diff --git a/crates/bevy_settings/src/lib.rs b/crates/bevy_settings/src/lib.rs index 8bfa67d44502b..2bd75d75086a7 100644 --- a/crates/bevy_settings/src/lib.rs +++ b/crates/bevy_settings/src/lib.rs @@ -298,7 +298,7 @@ fn save_preferences(world: &mut World, use_async: bool, force: bool) { // Update timestamps let mut registry = world.get_resource_mut::().unwrap(); - for (_, manifest) in registry.files.iter_mut() { + for manifest in registry.files.values_mut() { manifest.last_save = this_run; } } diff --git a/crates/bevy_ui/src/layout/convert.rs b/crates/bevy_ui/src/layout/convert.rs index 4e9e9134e05fd..ba648e30a69ab 100644 --- a/crates/bevy_ui/src/layout/convert.rs +++ b/crates/bevy_ui/src/layout/convert.rs @@ -642,18 +642,18 @@ mod tests { ); assert_eq!( taffy_style.grid_template_rows, - vec![sh::length(10.0), sh::percent(0.5), sh::fr(1.0)] + vec![sh::length(10_f32), sh::percent(0.5_f32), sh::fr(1_f32)] ); assert_eq!( taffy_style.grid_template_columns, - vec![sh::repeat(5, vec![sh::length(10.0)])] + vec![sh::repeat(5, vec![sh::length(10_f32)])] ); assert_eq!( taffy_style.grid_auto_rows, vec![ sh::fit_content(taffy::style::LengthPercentage::length(10.0)), sh::fit_content(taffy::style::LengthPercentage::percent(0.25)), - sh::minmax(sh::length(0.0), sh::fr(2.0)), + sh::minmax(sh::length(0_f32), sh::fr(2_f32)), ] ); assert_eq!( diff --git a/tools/build-templated-pages/src/features.rs b/tools/build-templated-pages/src/features.rs index da2761c8ebf7d..97cd38247c681 100644 --- a/tools/build-templated-pages/src/features.rs +++ b/tools/build-templated-pages/src/features.rs @@ -96,7 +96,7 @@ fn parse_features(panic_on_missing: bool) -> Vec { .flat_map(|v| v.as_str().map(|s| format!("`{}`", s))) .collect::>() .join(", "); - description.push_str(&format!(" **Feature set:** {}.", &features)); + description.push_str(&format!(" **Feature set:** {}.", features)); } Some(Feature { diff --git a/tools/example-showcase/src/main.rs b/tools/example-showcase/src/main.rs index dbc60564623bf..2650b5e29c922 100644 --- a/tools/example-showcase/src/main.rs +++ b/tools/example-showcase/src/main.rs @@ -613,16 +613,16 @@ required_features = {:?} WebApi::Webgl2 => "", }, to_show.category, - &to_show.technical_name.replace('_', "-"), - &to_show.technical_name.replace('_', "-"), + to_show.technical_name.replace('_', "-"), + to_show.technical_name.replace('_', "-"), match api { WebApi::Webgpu => "-webgpu", WebApi::Webgl2 => "", }, - &beautified_category, - &to_show.technical_name.replace('_', "-"), - &to_show.category, - &to_show.technical_name, + beautified_category, + to_show.technical_name.replace('_', "-"), + to_show.category, + to_show.technical_name, match api { WebApi::Webgpu => "-webgpu", WebApi::Webgl2 => "", @@ -633,7 +633,7 @@ required_features = {:?} .collect::() .display(), to_show.shader_paths, - &to_show.path, + to_show.path, match api { WebApi::Webgpu => "WebGPU", WebApi::Webgl2 => "WebGL2",