SceneSpawner: add unload() and unload_sync() #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
added
A-ECS
Fishrock123
force-pushed
the
scene-unload
branch
from
df1bd8e
to
3e37378
Compare
memoryruins
reviewed
Sep 1, 2020
Fishrock123
force-pushed
the
scene-unload
branch
from
3e37378
to
ec48348
Compare
cart
requested changes
Sep 4, 2020
This allows you to unload scenes. Refs: bevyengine#255
Fishrock123
force-pushed
the
scene-unload
branch
from
ec48348
to
203fe61
Compare
|
@cart Addressed and updated. |
cart
approved these changes
Sep 6, 2020
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
This allows you to unload scenes. Refs: bevyengine#255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to unload scenes.
Refs: #255
I've been struggling to get an example up that isn't just rewriting the breakout game to use scenes, maybe someone can help me make something simpler to properly verify this.