Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Stopwatch elapsed secs f64 #5978

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Stopwatch elapsed secs f64 #5978

wants to merge 3 commits into from

Conversation

EMachad0
Copy link
Contributor

Objective

While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.

Solution

  • added a function that returns the Stopwatch elapsed time as f64

Changelog

Added

  • Added a function to get Stopwatch elapsed time as f64

Fixed

  • The Stopwatch elapsed function had a wrong docs link

@alice-i-cecile alice-i-cecile added the C-Usability A simple quality-of-life change that makes Bevy easier to use label Sep 13, 2022
@alice-i-cecile
Copy link
Member

Pinging @cart to get an A-Time label :)

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this for consistency.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 13, 2022
@cart cart added the A-Time Involves time keeping and reporting label Sep 13, 2022
@cart cart changed the title Feat stopwatch elapsed secs f64 Stopwatch elapsed secs f64 Sep 13, 2022
@cart
Copy link
Member

cart commented Sep 13, 2022

@alice-i-cecile just added A-Time!

@cart
Copy link
Member

cart commented Sep 13, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 13, 2022
# Objective

While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.

## Solution

- added a function that returns the `Stopwatch` elapsed time as `f64`

---

## Changelog

### Added
- Added a function to get `Stopwatch` elapsed time as `f64`

### Fixed
- The Stopwatch elapsed function had a wrong docs link
@bors bors bot changed the title Stopwatch elapsed secs f64 [Merged by Bors] - Stopwatch elapsed secs f64 Sep 13, 2022
@bors bors bot closed this Sep 13, 2022
@EMachad0 EMachad0 deleted the feat_stopwatch_elapsed_secs_f64 branch September 14, 2022 13:26
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
# Objective

While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.

## Solution

- added a function that returns the `Stopwatch` elapsed time as `f64`

---

## Changelog

### Added
- Added a function to get `Stopwatch` elapsed time as `f64`

### Fixed
- The Stopwatch elapsed function had a wrong docs link
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.

## Solution

- added a function that returns the `Stopwatch` elapsed time as `f64`

---

## Changelog

### Added
- Added a function to get `Stopwatch` elapsed time as `f64`

### Fixed
- The Stopwatch elapsed function had a wrong docs link
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.

## Solution

- added a function that returns the `Stopwatch` elapsed time as `f64`

---

## Changelog

### Added
- Added a function to get `Stopwatch` elapsed time as `f64`

### Fixed
- The Stopwatch elapsed function had a wrong docs link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Time Involves time keeping and reporting C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants