Exception on certain filters.

[tangrl]

I gave "Linq to Querystring" a try but found a few problems. The filters with the following syntax all throw exceptions:

$filter=toupper(Login)%20eq%20'ABC'

$filter=toupper(Supervisor/Login)%20eq%20'ABC'

$filter=Supervisor/Login%20eq%20'ABC'

Excetions look like this:

{"$id":"1","Message":"An error has occurred.","ExceptionMessage":"Object reference not set to an instance of an object.","ExceptionType":"System.NullReferenceException","StackTrace":" at System.Web.Http.ApiController.d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Web.Http.Tracing.Tracers.HttpControllerTracer.d__5.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Web.Http.Tracing.ITraceWriterExtensions.d__21`1.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Web.Http.Dispatcher.HttpControllerDispatcher.d__0.MoveNext()"}

[beyond-code-github]

Hi there

Please see linqtoquerystring.net/features.html... tolower is supported but not toupper. I may add this at a future date if there is large demand but it is not supported natively by many NoSql providers.

Validity of the last one will depend on the structure of your model... i.e there must be a property 'Supervisor' of a type that then has a string property 'Login' as a member. If you can paste details of your model here then I can assist further and maybe help you to pinpoint the problem.

Apologies for the uninformative error messages, this is on the list to address too.

Pete

[tangrl]

Pete,
The reason I need "toupper" is the existing clients are consuming Microsoft implementation of Web Api + ODATA and most of them use "toupper". I need a graceful way to implement $inlinecount. My model should meet your requirement since it works with Microsoft version:
public class Person
{
public string Login { get; set; }
public Person Supervisor {get; set;}
...
}

Hmm, the recursive structure may throw your logic off, I guess?

Richard

[beyond-code-github]

Hmmm, in terms of the property accessor I would think $filter=Supervisor/Login%20eq%20'ABC' should work fine. Perhaps you could also provide code for the controller where you are using it?

As for the other issue... I will try to make toupper a priority for you.

[beyond-code-github]

Oh actually another thing to check... does the Supervisor field have a value when it comes back from the db? It could be that it's missing a .Include or this may be done automatically in the microsoft version.

[tangrl]

Pete,
All the data is from memory and the code looks like this:

    [LinqToQueryable]
    public IEnumerable<PersonModel> Get()
    {
        lock (CacheManager.Cache)
        {
            var personList = CacheManager.Cache.GetData(CacheManager.EMPLOYEE_DATA_CACHE_KEY) as List<PersonModel>;
            if (personList == null)
            {
                EmployeeDataCacheRefreshAction.RefreshEmployeeDataCache(new EmployeeDataCacheRefreshAction());
                personList = CacheManager.Cache.GetData(CacheManager.EMPLOYEE_DATA_CACHE_KEY) as List<PersonModel>;
            }
            return personList;
        }
    }

[tangrl]

Sorry, I posted the wrong code. The correct one should be:

[LinqToQueryable]
public IQueryable<PersonModel> Get()
{
    lock (CacheManager.Cache)
    {
        var personList = CacheManager.Cache.GetData(CacheManager.EMPLOYEE_DATA_CACHE_KEY) as List<PersonModel>;
        if (personList == null)
        {
            EmployeeDataCacheRefreshAction.RefreshEmployeeDataCache(new EmployeeDataCacheRefreshAction());
            personList = CacheManager.Cache.GetData(CacheManager.EMPLOYEE_DATA_CACHE_KEY) as List<PersonModel>;
        }
        return personList.AsQueryable();
    }
}

[beyond-code-github]

Sorry for the delay... have had a brainwave while looking at this again. Is it possible that one of the items in the personList is null? This would cause the exact error you have described...

[tangrl]

Pete,
I've just checked it and there wasn't any null items in the list.

[beyond-code-github]

Hmm ok... and any null Supervisor properties?

[tangrl]

Yes, the CEO of the company doesn't have a supervisor.

[beyond-code-github]

Ahaaaa.... ok that may give me something to work on. If you manually exclude him from the results does that work ok?

[tangrl]

Yes, it works!

[beyond-code-github]

I need to add some tests for this specific case to be 100% sure, but does this work for you?

$filter=Supervisor ne null and Supervisor/Login%20eq%20'ABC'

[beyond-code-github]

Just a reminder, if you can verify this works then I can close the issue.