Skip to content

Security vulnerability from project .ackrc files #399

Closed
@jimrandomh

Description

@jimrandomh

Running "ack" in a directory which contains a malicious .ackrc will cause code execution. This is similar to the old Unix issue where if you put "." on your path, you can be tricked into running something named "ls": an attacker might scatter .ackrc files in different locations. It's not a huge risk, but it seems worth fixing.

The problem is the --pager option: a .ackrc file could say "--pager=./malicious.sh" (or even "--pager=./.ackrc"). The solution would be to forbid that option (and maybe also --output=expr?) in project ackrc files (but still allow it in other places).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions