Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Security vulnerability from project .ackrc files #399

Closed
jimrandomh opened this Issue Nov 8, 2013 · 4 comments

Comments

Projects
None yet
3 participants

Running "ack" in a directory which contains a malicious .ackrc will cause code execution. This is similar to the old Unix issue where if you put "." on your path, you can be tricked into running something named "ls": an attacker might scatter .ackrc files in different locations. It's not a huge risk, but it seems worth fixing.

The problem is the --pager option: a .ackrc file could say "--pager=./malicious.sh" (or even "--pager=./.ackrc"). The solution would be to forbid that option (and maybe also --output=expr?) in project ackrc files (but still allow it in other places).

Collaborator

petdance commented Nov 15, 2013

The list of flags to forbid anywhere except your local .ackrc or command line: --pager, --regex and --output.

Collaborator

petdance commented Dec 3, 2013

ack 2.12 has been release that disallows --pager, --regex and --output in project .ackrcs.

@petdance petdance closed this Dec 3, 2013

xtaran commented Dec 12, 2013

The CVE ID "CVE-2013-7069" has been assigned to this issue.

Collaborator

petdance commented Dec 13, 2013

@jimrandomh: Thank you very much for bringing this to my attention.

I have put up a security alert at http://beyondgrep.com/security/

@hoelzro hoelzro referenced this issue in Homebrew/legacy-homebrew Dec 13, 2013

Closed

ack 2.12 #25176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment