New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for ignoring a subdir: Fix for #541 #570

Merged
merged 1 commit into from Sep 21, 2015

Conversation

Projects
None yet
3 participants
@openstrike
Contributor

openstrike commented Sep 21, 2015

This PR extends the test file ack-ignore-dir.t to confirm that a subdir of a specified target is still ignored when it matches the --ignore-dir pattern. It's a fix for issue #541.

New test for ignoring a subdir: Fix for #541
Other tests affected by this extra dir and file amended to cope.
@hoelzro

This comment has been minimized.

Show comment
Hide comment
@hoelzro

hoelzro Sep 21, 2015

Collaborator

This looks good to me! @petdance Are you ok with me merging this?

Collaborator

hoelzro commented Sep 21, 2015

This looks good to me! @petdance Are you ok with me merging this?

@petdance

This comment has been minimized.

Show comment
Hide comment
@petdance

petdance Sep 21, 2015

Collaborator

ok. Please make sure the Change log gets updated.

Collaborator

petdance commented Sep 21, 2015

ok. Please make sure the Change log gets updated.

hoelzro added a commit that referenced this pull request Sep 21, 2015

Merge pull request #570 from openstrike/issue541
New test for ignoring a subdir: Fix for #541

@hoelzro hoelzro merged commit b69a4be into beyondgrep:dev Sep 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment