New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --output test script #532 #587

Merged
merged 1 commit into from Jan 1, 2016

Conversation

Projects
None yet
3 participants
@Varadinsky
Contributor

Varadinsky commented Dec 29, 2015

Part of my pull request challenge for this month. :-)

@hoelzro

This comment has been minimized.

Show comment
Hide comment
@hoelzro

hoelzro Dec 29, 2015

Collaborator

Looks good to me! @petdance any thoughts?

Collaborator

hoelzro commented Dec 29, 2015

Looks good to me! @petdance any thoughts?

@petdance

This comment has been minimized.

Show comment
Hide comment
@petdance

petdance Dec 30, 2015

Collaborator

Nice. It looks pretty complete, although I think I'd feel a bit better if there were also tests where it finds more than one hit in more than one file. I think we can merge this and then add to it. And make sure we put in a credit for Varadinsky in the ACKnowledgements.

Collaborator

petdance commented Dec 30, 2015

Nice. It looks pretty complete, although I think I'd feel a bit better if there were also tests where it finds more than one hit in more than one file. I think we can merge this and then add to it. And make sure we put in a credit for Varadinsky in the ACKnowledgements.

hoelzro added a commit that referenced this pull request Jan 1, 2016

@hoelzro hoelzro merged commit efbf766 into beyondgrep:dev Jan 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hoelzro

This comment has been minimized.

Show comment
Hide comment
@hoelzro

hoelzro Jan 1, 2016

Collaborator

Merged! @Varadinsky How would you like to be referred to in the acknowledgements?

@petdance Is a new test file Changes-worthy?

Collaborator

hoelzro commented Jan 1, 2016

Merged! @Varadinsky How would you like to be referred to in the acknowledgements?

@petdance Is a new test file Changes-worthy?

@hoelzro

This comment has been minimized.

Show comment
Hide comment
@hoelzro

hoelzro Jan 1, 2016

Collaborator

@petdance I just added it to Changes, since we can always pull it out if needed.

Collaborator

hoelzro commented Jan 1, 2016

@petdance I just added it to Changes, since we can always pull it out if needed.

@Varadinsky

This comment has been minimized.

Show comment
Hide comment
@Varadinsky

Varadinsky Jan 1, 2016

Contributor

Thanks!
@petdance - I will add some more tests to t/ack-output.t.
@hoelzro - Varadinsky is fine. :-)

Contributor

Varadinsky commented Jan 1, 2016

Thanks!
@petdance - I will add some more tests to t/ack-output.t.
@hoelzro - Varadinsky is fine. :-)

@Varadinsky Varadinsky deleted the Varadinsky:test-output branch Jan 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment