Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make t/ack-man.t and t/invalid-ackrc.t work under Travis #176

Open
petdance opened this issue Jan 1, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@petdance
Copy link
Collaborator

commented Jan 1, 2019

We've had to SKIP tests in two tests under Travis because Travis can't find stty in its path. Solve this problem.

@petdance petdance added the internals label Jan 1, 2019

@petdance

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 1, 2019

Sample failure:

t/ack-man.t .................. 
    #   Failed test 'Nothing in STDERR'
    #   at t/ack-man.t line 60.
    # [
    #   'stty: standard input: Inappropriate ioctl for device'
    # ]
        #   Failed test 'Found one (?^ms:^AUTHOR$) section'
        #   at t/ack-man.t line 108.
        #          got: '0'
        #     expected: '1'
        # Looks like you failed 1 test of 1.
    #   Failed test 'want( (?^ms:^AUTHOR$) )'
    #   at t/ack-man.t line 62.
    # Looks like you failed 2 tests of 3.
@petdance

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 1, 2019

Working on this in the pathing branch.

@petdance

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 1, 2019

Reading this thread makes me think it might be something Travis does with STDIN.

https://unix.stackexchange.com/questions/157852/echo-test-stty-echo-stty-standard-input-inappropriate-ioctl-for-device

@petdance

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 1, 2019

Travis can't find stty in its path

That's wrong. The problem is that perldoc doesn't run right in whatever environment Travis has set up. So when running under Travis, don't use perldoc.

Fixed in 589cdb7 on dev.

@petdance petdance closed this Jan 1, 2019

@eserte

This comment has been minimized.

Copy link

commented May 29, 2019

@petdance: I see this problem also on some of my smokers --- currently there are 26 fails vs. 85 passes. I don't see a pattern regarding OS or perl version. It seems to happen more often on Debian-based systems (Debian and Ubuntu), and almost never on Fedora-based systems (just a few fails on CentOS6). The problem does not happen on my FreeBSD systems.

@petdance

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

You're saying this still happens with v3.0.0?

@petdance petdance reopened this May 29, 2019

@eserte

This comment has been minimized.

Copy link

commented Jun 26, 2019

I see ack-man.t and invalid-ackrc.t failures also with v3.0.1:

#   Failed test 'Nothing in STDERR'
#   at t/ack-man.t line 22.
# [
#   'stty: Standardeingabe: Unpassender IOCTL (I/O-Control) für das Gerät'
# ]
# Looks like you failed 1 test of 3.
t/ack-man.t .................. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
...
    
    #   Failed test 'Should have no output to stderr: ack --env --man'
    #   at t/invalid-ackrc.t line 78.
    #          got: '1'
    #     expected: '0'
    # STDERR:
    # stty: Standardeingabe: Unpassender IOCTL (I/O-Control) für das Gerät
    # Looks like you failed 1 test of 2.

#   Failed test 'Check --env --man'
#   at t/invalid-ackrc.t line 83.
# Looks like you failed 1 test of 3.
t/invalid-ackrc.t ............ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.