cmd: Move definitions here as described in GSP-139 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 17.57% 17.57%
=======================================
Files 19 19
Lines 768 768
=======================================
Hits 135 135
Misses 626 626
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
8 tasks
xxchan
reviewed
Jul 9, 2021
| @@ -120,7 +121,7 @@ type Pair struct { | |||
| } | |||
|
|
|||
| func (p *Pair) Type() string { | |||
| return parseType(p.ptype) | |||
| return p.ptype | |||
There was a problem hiding this comment.
Because we won't share definitions across languages, so we can remove the extra type translation layer here.
xxchan
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we can refactor them later, but in this PR, we just copy them here.
Signed-off-by: Xuanwo github@xuanwo.io