Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container/image id is given as nil. #157

Merged
merged 1 commit into from Jun 24, 2014
Merged

container/image id is given as nil. #157

merged 1 commit into from Jun 24, 2014

Conversation

ageekymonk
Copy link

For a new_resource id is returned to be nil. So ignoring the check.
Also the -notrunc is deprecated. moving it to --no-trunc.

…r null. Also the -notrunc is deprecated. moving it to --no-trunc.
@amjibaly
Copy link

amjibaly commented Jun 5, 2014

+1 I'm running into the same issue and this patch resolved it. Can anyone shed light on what new_resource is and under what conditions this is an issue?

@jcrobak
Copy link

jcrobak commented Jun 17, 2014

this shouldn't change behavior in the case of new_resource.id being nil. In that case, container_id_matches? will always return false, and you will go into the body of the unless.

Or is my logic wrong here?

@bflad
Copy link
Contributor

bflad commented Jun 24, 2014

I think I'm going to merge this as it relates to #139, #153, and #154 and contains the -notrunc deprecation fix. Can we please verify matching works in the next release of the cookbook (0.35.0 or 1.0.0)? We can always add the additional check back in as a bugfix that needs test cases. 😉

bflad added a commit that referenced this pull request Jun 24, 2014
container/image id is given as nil.
@bflad bflad merged commit 1fed0b6 into sous-chefs:master Jun 24, 2014
bflad added a commit that referenced this pull request Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants