Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passes/R006: Add -package-aliases flag #239

Merged
merged 1 commit into from Jul 2, 2021
Merged

passes/R006: Add -package-aliases flag #239

merged 1 commit into from Jul 2, 2021

Conversation

bflad
Copy link
Owner

@bflad bflad commented Jul 1, 2021

Certain providers may wish to shim helper/resource functionality to prevent multiple module version issues while upgrading. When using type aliasing for RetryError and method expressions for RetryableError (or a passthrough implementation), the R006 pass cannot be satisfied due to the mismatched package naming of RetryableError. Instead, we can allow callers to declare their alias/shim package paths to additionally ignore reports. The only requirement is that the shimmed method expression or function name must still be RetryableError.

Certain providers may wish to shim `helper/resource` functionality to prevent multiple module version issues while upgrading. When using type aliasing for `RetryError` and method expressions for `RetryableError` (or a passthrough implementation), the `R006` pass cannot be satisfied due to the mismatched package naming of `RetryableError`. Instead, we can allow callers to declare their alias/shim package paths to additionally ignore reports. The only requirement is that the shimmed method expression or function name must still be `RetryableError`.
@bflad bflad added enhancement ast cli check/resource labels Jul 1, 2021
@bflad bflad self-assigned this Jul 2, 2021
@bflad bflad added this to the v0.27.0 milestone Jul 2, 2021
@bflad bflad merged commit cdedb98 into main Jul 2, 2021
6 checks passed
@bflad bflad deleted the f-R006-package-aliases branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast check/resource cli enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant