passes/R006: Add -package-aliases flag
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain providers may wish to shim `helper/resource` functionality to prevent multiple module version issues while upgrading. When using type aliasing for `RetryError` and method expressions for `RetryableError` (or a passthrough implementation), the `R006` pass cannot be satisfied due to the mismatched package naming of `RetryableError`. Instead, we can allow callers to declare their alias/shim package paths to additionally ignore reports. The only requirement is that the shimmed method expression or function name must still be `RetryableError`.
bflad
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Certain providers may wish to shim
helper/resourcefunctionality to prevent multiple module version issues while upgrading. When using type aliasing forRetryErrorand method expressions forRetryableError(or a passthrough implementation), theR006pass cannot be satisfied due to the mismatched package naming ofRetryableError. Instead, we can allow callers to declare their alias/shim package paths to additionally ignore reports. The only requirement is that the shimmed method expression or function name must still beRetryableError.