Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XS001 and XR005 to allow more ways of setting Description #242

Merged
merged 1 commit into from Jul 20, 2021

Conversation

armsnyder
Copy link
Contributor

@armsnyder armsnyder commented Jul 20, 2021

fixes #240
fixes #241

Reduces false positives by checking for field existence instead of string value.

@bflad bflad self-assigned this Jul 20, 2021
@bflad bflad added ast bug check/resource check/schema labels Jul 20, 2021
@bflad bflad added this to the v0.27.1 milestone Jul 20, 2021
bflad
bflad approved these changes Jul 20, 2021
Copy link
Owner

@bflad bflad left a comment

Looks good to me, thank you for raising these issues and contributing these fixes. 🚀 We may want these checks to still disallow "" (empty string) if a string literal is provided, however the tests were not covering this and not sure if folks are dependent on that particular edge case.

@bflad bflad merged commit c322e1e into bflad:main Jul 20, 2021
3 checks passed
bflad added a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast bug check/resource check/schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants