-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reconstruction chain in the webApp #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! General comments:
- the key "new" for the new chain is not ideal, because as soon as we add a third chain (or a small variation of one of the current two chains) it will have to be changed
- following the same reasoning, it is likely better to use a widget with more than two options
I've added a dropdown menu instead of a switch so that we can easily add multiple chains in the code. Now the new chain is called coarse seeding chain. |
Additional minor comments:
Once this is addressed I am ready to approve. What about @isehle? |
Implementations done! Now the page layout is a bit better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set. Thank you for all the work, and for addressing the (many) comments.
In this PR, I have added the possibility to run the new reconstruction chain from the 3D display app, allowing users to view its outputs on the screen. Users now have the option to display cluster seeds from the new reconstruction chain, which includes the new coarse seeding and the new seeding algorithm, or from the default chain by simply interacting with a switch.
The scripts required to run the new reconstruction chain were already present in the Python framework. When calling for new events from the app, both chains are executed, so that the final user can compare the two chains applied to the same event. The
new_radii_chain
function has been updated accordingly. The dataframes are then processed and stored in the usual hdf5 files, where a new key has been added. This key allows for distinguishing between the new chain and the default chain and can assume the values of 'new' or 'default'.Here's an example of a photon (200 pileup) processed by both chains. The difference in performance is truly impressive.
![image](https://private-user-images.githubusercontent.com/67897021/273461760-c78147f2-af50-4191-af08-18d1b8317d87.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxMTA1ODIsIm5iZiI6MTcyNTExMDI4MiwicGF0aCI6Ii82Nzg5NzAyMS8yNzM0NjE3NjAtYzc4MTQ3ZjItYWY1MC00MTkxLWFmMDgtMThkMWI4MzE3ZDg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODMxVDEzMTgwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4YTdjOWMyMzM4ZmRhOWY2YWY4NTgzNDgzNDhmZDlmMGM3OThlZjgyOWU1M2JhZDExNTMzMWZhNTQ0YTk0MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qtwLs44WM1MdoZK-na6xMouhk3-WZiTdL0gPHn98zYs)
![image](https://private-user-images.githubusercontent.com/67897021/273461781-b4283b4b-73cc-4c2b-a0bd-e4def4273b5c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxMTA1ODIsIm5iZiI6MTcyNTExMDI4MiwicGF0aCI6Ii82Nzg5NzAyMS8yNzM0NjE3ODEtYjQyODNiNGItNzNjYy00YzJiLWEwYmQtZTRkZWY0MjczYjVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODMxVDEzMTgwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI1ZWUwZjYwMTRmYTExZDNjNDljNWRkYzc1YjIwYTEwNTQxMGRhZDc2NWMzY2E5NmVlNzc5MzU0ODY2MWFiY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tPSISfrRRWF4eA4_fbcBrgdUCWebOoy-hY76D6WsqPc)