Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop `.define` #21

Merged
merged 15 commits into from Jun 23, 2019

Conversation

Projects
None yet
1 participant
@bfred-it
Copy link
Owner

commented Jun 10, 2019

No description provided.

@bfred-it bfred-it force-pushed the deprecate-define branch from b94b58e to ba97e01 Jun 10, 2019

@bfred-it

This comment has been minimized.

Copy link
Owner Author

commented Jun 10, 2019

I don’t know how this can be solved in any other way:

source/index.ts:71:14
✖ 71:14 Type assertion on object literals is forbidden, use a type annotation instead. @typescript-eslint/no-object-literal-type-assertion

Without as it will fail to match the Record type 😕

@bfred-it

This comment has been minimized.

Copy link
Owner Author

commented Jun 23, 2019

🤦‍♂️ microsoft/TypeScript#29952
The solution: use assertions {} as Type

@bfred-it bfred-it merged commit 62d148c into master Jun 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bfred-it bfred-it deleted the deprecate-define branch Jun 23, 2019

bfred-it added a commit that referenced this pull request Jun 23, 2019

Drop `.define` (#21)
Definitions are now part of the constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.