prevent negative hue#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a subtle edge case in the RGB-to-HSV color conversion logic and adds a corresponding test to ensure correct behavior. The main focus is on handling hue values that would otherwise be negative, ensuring they wrap correctly as in OpenCV.
Color conversion bug fix:
cvtcolormodule to use.rem_euclid(6.0)instead of% 6.0, ensuring that negative hue values are wrapped correctly rather than producing unexpected results. This change aligns the behavior with OpenCV's implementation.Testing improvements:
test_rgb_to_hsv_wraps_negative_red_sector_hues) incv_compat_teststo verify that the hue wraps properly for RGB values in the red sector whereg < b, matching OpenCV's expected output.