Improve syntax + code formatting #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve syntax and code formatting
|
Gracias por su correo.. pero soy de tercera edad y no se leer su página
web. por estar en inglés.
El mié., 29 de noviembre de 2023 12:41, Matheus ***@***.***>
escribió:
… Hi! I just made some changes to improve code syntax and formatting.
First changes:
Replacing != with !==
Replacing == with ===
To strictly check both value and type. This is generally a good practice
if you want to ensure strict equality.
Second changes:
Removing an unused event parameter
Last changes:
Running alt + shift + f for better code formatting. Formatting the code
consistently improves readability and makes it easier for others to
understand.
------------------------------
You can view, comment on, or merge this pull request online at:
#39
Commit Summary
- 094d47d
<094d47d>
Improve code syntax + code formatting
- 0e0ef3b
<0e0ef3b>
code formatting
- de2540f
<de2540f>
Merge pull request #1 from Matheus-gs/improve_syntax_and_code_formatting
File Changes
(2 files <https://github.com/bgstaal/multipleWindow3dScene/pull/39/files>)
- *M* WindowManager.js
<https://github.com/bgstaal/multipleWindow3dScene/pull/39/files#diff-333584d629f92a1f65d4bfd3721df9ddb832bcf53507187ba575af720454cfd0>
(272)
- *M* main.js
<https://github.com/bgstaal/multipleWindow3dScene/pull/39/files#diff-58417e0f781b6656949d37258c8b9052ed266e2eb7a5163cad7b0863e6b2916a>
(318)
Patch Links:
- https://github.com/bgstaal/multipleWindow3dScene/pull/39.patch
- https://github.com/bgstaal/multipleWindow3dScene/pull/39.diff
—
Reply to this email directly, view it on GitHub
<#39>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEJM2TIH6BZNP34LBIAYVLTYG56VNAVCNFSM6AAAAAA776EXVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTOMJZHE2DSOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I just made some changes to improve code syntax and formatting.
First changes:
Replacing != with !==
Replacing == with ===
To strictly check both value and type. This is generally a good practice if you want to ensure strict equality.
Second changes:
Removing an unused event parameter
Last changes:
Running alt + shift + f for better code formatting. Formatting the code consistently improves readability and makes it easier for others to understand.