Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to typescript #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Move to typescript #51

wants to merge 5 commits into from

Conversation

bguerout
Copy link
Owner

  • Update README
  • Rework dist to expose cjs and mjs exports
  • Rename all files to *.mjs
  • WIP
  • Move to typescript
  • Add first types

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (26db57f) 97.27% compared to head (7098584) 93.12%.

Files Patch % Lines
src/writeData.ts 68.33% 9 Missing and 10 partials ⚠️
src/utils/toAsyncIterator.ts 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   97.27%   93.12%   -4.16%     
==========================================
  Files          21       21              
  Lines         367      378      +11     
  Branches        0       69      +69     
==========================================
- Hits          357      352       -5     
- Misses         10       11       +1     
- Partials        0       15      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@antoinebigard antoinebigard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 merci de cette update

@bguerout
Copy link
Owner Author

bguerout commented Dec 8, 2023

Hello 👋 merci de cette update

Pour l'instant c'est une migration light et au final ca reste du code js mais je vais essayer de passer un peu de temps pour créer les types

@bguerout bguerout force-pushed the typscript branch 19 times, most recently from 574f5a5 to 465ecbd Compare December 10, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants