Skip to content

Improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2020
Merged

Improvements #10

merged 8 commits into from
Aug 18, 2020

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Oct 24, 2018

  • Actualize Ruby versions for Travis CI
    Ruby 2.2 and 2.3 and below are not supported anymore.
  • Don't require system (bundled) gems
  • Use require_relative instead of require
    Don't require files from installed gem.
  • Update dependencies, improve versions locks
    Alpha-versions (0.x.y) should be locked on y (patch version),
    because of x (minor version) update may brings breaking changes.
  • Fix tests for Users and Users Stats
    Some profiles become private (closed), some was renamed.
  • Replace deprecated Fixnum with Integer
    Remove Ruby warnings.

Ruby 2.2 and below are not supported anymore.
Don't require files from installed gem.
Some profiles become private (closed), some was renamed.
Alpha-versions (`0.x.y`) should be locked on `y` (patch version),
because of `x` (minor version) update may brings breaking changes.
@AlexWayfer
Copy link
Contributor Author

@bhaberer, I've made more updates and improvements! Are you interested in this gem? I can help to maintain, if you'd like.

@bhaberer
Copy link
Owner

@AlexWayfer thanks for the work, I'll take a look soon! I missed the last one somehow.

@AlexWayfer
Copy link
Contributor Author

@bhaberer thank you, here is just a friendly reminder!

@AlexWayfer
Copy link
Contributor Author

@bhaberer and another one…

@AlexWayfer
Copy link
Contributor Author

I have now failed specs, but I don't know how to fix them:

Failures:

  1) Steam::Player.recently_played_games returns the list of games
     Failure/Error: expect(p(result)).to have_key('games')
       expected #has_key?("games") to return true, got false
     # ./spec/steam/player_spec.rb:34:in `block (3 levels) in <top (required)>'

  2) Steam::Player.recently_played_games returns the recent playtime for games
     Failure/Error: expect(result['games'].first).to have_key('playtime_2weeks')
     
     NoMethodError:
       undefined method `first' for nil:NilClass
     # ./spec/steam/player_spec.rb:38:in `block (3 levels) in <top (required)>'

  3) Steam::Player.recently_played_games returns the full playtime for games
     Failure/Error: expect(result['games'].first).to have_key('playtime_forever')
     
     NoMethodError:
       undefined method `first' for nil:NilClass
     # ./spec/steam/player_spec.rb:42:in `block (3 levels) in <top (required)>'

Finished in 1 minute 51.05 seconds (files took 0.12711 seconds to load)
78 examples, 3 failures

Failed examples:

rspec ./spec/steam/player_spec.rb:33 # Steam::Player.recently_played_games returns the list of games
rspec ./spec/steam/player_spec.rb:37 # Steam::Player.recently_played_games returns the recent playtime for games
rspec ./spec/steam/player_spec.rb:41 # Steam::Player.recently_played_games returns the full playtime for games

In the future, we will need for cassettes, like VCR.

@AlexWayfer
Copy link
Contributor Author

@bhaberer yet another friendly reminder.

@AlexWayfer
Copy link
Contributor Author

@bhaberer when this "soon" will be? 😰

@bhaberer
Copy link
Owner

Sorry I'm the worst, I'll look at this now 😅

Copy link
Owner

@bhaberer bhaberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge and package a new ver soon

@bhaberer bhaberer merged commit 518b30c into bhaberer:master Aug 18, 2020
@AlexWayfer
Copy link
Contributor Author

LGTM, I'll merge and package a new ver soon

Thank you!

@AlexWayfer AlexWayfer deleted the improvements branch October 28, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants