-
Notifications
You must be signed in to change notification settings - Fork 28
Improvements #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #10
Conversation
Ruby 2.2 and below are not supported anymore.
Don't require files from installed gem.
Ruby 2.3 is no longer maintained: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
Some profiles become private (closed), some was renamed.
Alpha-versions (`0.x.y`) should be locked on `y` (patch version), because of `x` (minor version) update may brings breaking changes.
@bhaberer, I've made more updates and improvements! Are you interested in this gem? I can help to maintain, if you'd like. |
@AlexWayfer thanks for the work, I'll take a look soon! I missed the last one somehow. |
@bhaberer thank you, here is just a friendly reminder! |
@bhaberer and another one… |
Remove Ruby warnings.
I have now failed specs, but I don't know how to fix them:
In the future, we will need for cassettes, like VCR. |
@bhaberer yet another friendly reminder. |
@bhaberer when this "soon" will be? 😰 |
Sorry I'm the worst, I'll look at this now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll merge and package a new ver soon
Thank you! |
Ruby 2.2 and 2.3 and below are not supported anymore.
require_relative
instead ofrequire
Don't require files from installed gem.
Alpha-versions (
0.x.y
) should be locked ony
(patch version),because of
x
(minor version) update may brings breaking changes.Some profiles become private (closed), some was renamed.
Fixnum
withInteger
Remove Ruby warnings.