Improvements#10
Merged
Merged
Conversation
Ruby 2.2 and below are not supported anymore.
Don't require files from installed gem.
Ruby 2.3 is no longer maintained: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
Some profiles become private (closed), some was renamed.
Alpha-versions (`0.x.y`) should be locked on `y` (patch version), because of `x` (minor version) update may brings breaking changes.
Contributor
Author
|
@bhaberer, I've made more updates and improvements! Are you interested in this gem? I can help to maintain, if you'd like. |
Owner
|
@AlexWayfer thanks for the work, I'll take a look soon! I missed the last one somehow. |
Contributor
Author
|
@bhaberer thank you, here is just a friendly reminder! |
Contributor
Author
|
@bhaberer and another one… |
Remove Ruby warnings.
Contributor
Author
|
I have now failed specs, but I don't know how to fix them: In the future, we will need for cassettes, like VCR. |
Contributor
Author
|
@bhaberer yet another friendly reminder. |
Contributor
Author
|
@bhaberer when this "soon" will be? 😰 |
Owner
|
Sorry I'm the worst, I'll look at this now 😅 |
bhaberer
approved these changes
Aug 18, 2020
bhaberer
left a comment
Owner
There was a problem hiding this comment.
LGTM, I'll merge and package a new ver soon
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.2 and 2.3 and below are not supported anymore.
require_relativeinstead ofrequireDon't require files from installed gem.
Alpha-versions (
0.x.y) should be locked ony(patch version),because of
x(minor version) update may brings breaking changes.Some profiles become private (closed), some was renamed.
FixnumwithIntegerRemove Ruby warnings.