Skip to content

Commit

Permalink
Fixed broken link in page menu for /Ticket/ModifyIDoitObjects.html af…
Browse files Browse the repository at this point in the history 
…ter update

* Fix: fetching ticket id
* Fix: meta data
  • Loading branch information
@bheisig
bheisig committed Jan 14, 2013
1 parent 65e1ab1 commit 4e8fdec
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 55 deletions.
51 changes: 26 additions & 25 deletions Changes
View file
@@ -1,47 +1,48 @@
Revision history for RT-Extension-ReferenceIDoitObjects

0.92 Fri, 07 Sep 2012 16:17:06 +0200
Implemented browser in "Jumbo update".
Hide custom fields when modifying referenced objects.
Removed buggy unused code.
0.92 - unreleased -
* Implemented browser in "Jumbo update"
* Hide custom fields when modifying referenced objects
* Removed buggy unused code
* Updated to Module::Install 1.06 (thanks to Tatsuhiko Miyagawa)

0.91 Fri, 07 Sep 2012 14:02:49 +0200
Removed deprecated Switch.pm (important for newer Perl versions; thanks to Matthias).
Described installation via CPAN.
* Removed deprecated Switch.pm (important for newer Perl versions; thanks to Matthias)
* Described installation via CPAN.

0.9 Mon, 04 Jun 2012 16:50:31 +0200
Include javascript and css only if needed.
Added checkbox to select/unselect all objects from object view.
Added link to remove all selected objects from list.
Show message if no requestor is selected.
Implemented workaround for JavaScript's JSON object missing in IE < 9.
* Include javascript and css only if needed
* Added checkbox to select/unselect all objects from object view
* Added link to remove all selected objects from list
* Show message if no requestor is selected
* Implemented workaround for JavaScript's JSON object missing in IE < 9

0.8 Fri, 01 Jun 2012 14:12:24 +0200
Show link in the page menu to modify referenced i-doit objects.
* Show link in the page menu to modify referenced i-doit objects

0.7 Thu, 31 May 2012 10:01:16 +0200
Use default mandator if necessary when modifying referenced i-doit objects.
Look only for enabled object types (bug fix).
* Use default mandator if necessary when modifying referenced i-doit objects
* Look only for enabled object types (bug fix)

0.6 Fri, 27 Apr 2012 11:49:06 +0200
Write logbook entries within i-doit when objects are added or removed.
Show loading message when initiating the browser.
Requires i-doit version 0.9.9-9 or higher.
* Write logbook entries within i-doit when objects are added or removed
* Show loading message when initiating the browser
* Requires i-doit version 0.9.9-9 or higher

0.5 Mon, 23 Apr 2012 13:22:37 +0200
When creating a ticket assign mandator and objects from HTTP GET.
Bug fixing.
* When creating a ticket assign mandator and objects from HTTP GET
* Bug fixing

0.4 skipped

0.3 Mon, 13 Feb 2012 13:28:50 +0100
Performance boost when rendering tables
Fixed API call when viewing a ticket created by email
Improved error messages
Improved meta information
* Performance boost when rendering tables
* Fixed API call when viewing a ticket created by email
* Improved error messages
* Improved meta information

0.2 Fri, 20 Jan 2012 15:45:43 +0100
Bug fixing.
* Bug fixing

0.1 Wed, 14 Dec 2011 09:30:22 +0100
Initial release.
* Initial release
23 changes: 23 additions & 0 deletions MANIFEST
View file
Expand Up @@ -21,17 +21,40 @@ html/Ticket/Elements/ShowIDoitObjects
html/Ticket/ModifyIDoitObjects.html
inc/Module/AutoInstall.pm
inc/Module/Install.pm
inc/Module/Install/Admin.pm
inc/Module/Install/Admin/Bundle.pm
inc/Module/Install/Admin/Compiler.pm
inc/Module/Install/Admin/Find.pm
inc/Module/Install/Admin/Include.pm
inc/Module/Install/Admin/Makefile.pm
inc/Module/Install/Admin/Manifest.pm
inc/Module/Install/Admin/Metadata.pm
inc/Module/Install/Admin/ScanDeps.pm
inc/Module/Install/Admin/WriteAll.pm
inc/Module/Install/AutoInstall.pm
inc/Module/Install/Base.pm
inc/Module/Install/Bundle.pm
inc/Module/Install/Can.pm
inc/Module/Install/Compiler.pm
inc/Module/Install/Deprecated.pm
inc/Module/Install/DSL.pm
inc/Module/Install/External.pm
inc/Module/Install/Fetch.pm
inc/Module/Install/Include.pm
inc/Module/Install/Inline.pm
inc/Module/Install/Makefile.pm
inc/Module/Install/MakeMaker.pm
inc/Module/Install/Metadata.pm
inc/Module/Install/PAR.pm
inc/Module/Install/Philosophy.pod
inc/Module/Install/ReadmeFromPod.pm
inc/Module/Install/RTx.pm
inc/Module/Install/RTx/Factory.pm
inc/Module/Install/Run.pm
inc/Module/Install/Scripts.pm
inc/Module/Install/Share.pm
inc/Module/Install/Win32.pm
inc/Module/Install/With.pm
inc/Module/Install/WriteAll.pm
lib/RT/Extension/ReferenceIDoitObjects.pm
Makefile.PL
Expand Down
59 changes: 41 additions & 18 deletions SIGNATURE
View file
Expand Up @@ -14,8 +14,8 @@ not run its Makefile.PL or Build.PL.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

SHA1 9ee2d8244c34db38f9d45ff7b8ae749caf7cf07c Changes
SHA1 47b16daddef5a1707ab0937569d6bdc8de2c5fee MANIFEST
SHA1 beb68d41f0ddbdf0def3919a5c34a13247e5a2a7 Changes
SHA1 50334a73c918d80ad88264dba24efd7185fe83ec MANIFEST
SHA1 30732a5045c730baf75d689f6ffbce7669da7da6 MANIFEST.SKIP
SHA1 25bc9212b421d131d61d7f8e4bf133ae9e1eb307 META.yml
SHA1 4894a510e5bc7202f9471782a495dcdf94111054 Makefile.PL
Expand All @@ -24,7 +24,7 @@ SHA1 676583b776bf7a2500ff9067ea3474fb005da96c TODO
SHA1 49701a1582499c03b668cb0607e6e2880fe71909 etc/i-doit_api_proxy.php
SHA1 e1e604e5d2bbb842d030132c60f56692f814a468 etc/initialdata
SHA1 8a587aebb1c722efe44a3940e247a82d2430bc6d html/Callbacks/ReferenceIdoitObjects/Elements/Header/Head
SHA1 e163c6c31431d31bee759dc75f91c6eef211399b html/Callbacks/ReferenceIdoitObjects/Elements/Tabs/Privileged
SHA1 32eac2d2a4b5ae4d5b7cdd980db74c0bd88ea603 html/Callbacks/ReferenceIdoitObjects/Elements/Tabs/Privileged
SHA1 4c89e02668a080563ab94d5bd9c76c13d853524c html/Callbacks/ReferenceIdoitObjects/Ticket/Create.html/AfterBasics
SHA1 480ad3b74dd93bc420497555fd0d7079dbb55a04 html/Callbacks/ReferenceIdoitObjects/Ticket/Create.html/FormStart
SHA1 c71887d1107cdcfc9c83487d0ec0e70f32993c81 html/Callbacks/ReferenceIdoitObjects/Ticket/Elements/ShowSummary/LeftColumn
Expand All @@ -40,21 +40,44 @@ SHA1 744360fe7ad612bddab3537c9b6d9688f5d4af41 html/NoAuth/js/i-doit_object_brows
SHA1 6f6c12b01532eeebefde965a5fa832a9d441122c html/NoAuth/js/jquery.dataTables.min.js
SHA1 2e9f9445ac8e4abbae95fe092f9212810484872c html/Ticket/Elements/EditIDoitObjects
SHA1 370b4e858d38606a6298c3aa26a92f03123959a3 html/Ticket/Elements/ShowIDoitObjects
SHA1 104c283adf9cc0b2afb4855918f647a4727afefd html/Ticket/ModifyIDoitObjects.html
SHA1 59e69e8b99149999c0c74e6031def042569410aa inc/Module/AutoInstall.pm
SHA1 eba6465ce5287959acc940e75b080205960b7ac6 inc/Module/Install.pm
SHA1 9dc7102b5e2c3a791205ecc4f9d84a56632253ef inc/Module/Install/AutoInstall.pm
SHA1 b1cf7431800187990981684e7f67e572e8f7a631 inc/Module/Install/Base.pm
SHA1 8550a7c7d2ed0632f8bdb3b741dfccaa013a1403 inc/Module/Install/Can.pm
SHA1 73b01297ba83de8dbe4a87f70bbad0460f973ae2 inc/Module/Install/Fetch.pm
SHA1 cb6547200d5494081535f3d91d76dc4364ad1029 inc/Module/Install/Include.pm
SHA1 318ae9c85a1e1c4b7be1586e7e93713714ba93f8 inc/Module/Install/Makefile.pm
SHA1 27edaaee2dc9d9b0be98e09ae82e5fe81cd58ba6 inc/Module/Install/Metadata.pm
SHA1 21829ff9d40b591b4cf18e7faf9fa449670a8876 html/Ticket/ModifyIDoitObjects.html
SHA1 232f4c97414c56d94f3b58d1d6a980ed4b7b72ce inc/Module/AutoInstall.pm
SHA1 08297ddab7b9077cd14c569694c07a1cff0e6e81 inc/Module/Install.pm
SHA1 6f600f997754e378372022338397e11304bcd4a1 inc/Module/Install/Admin.pm
SHA1 cd0a3b098547ab4e8ade00c5330aa9f6b3b8da1c inc/Module/Install/Admin/Bundle.pm
SHA1 cb5e4e4e7ed502288b859696fac6bd88761b5095 inc/Module/Install/Admin/Compiler.pm
SHA1 ade2cd33c1dd7a50ca7a583c038c1bae3e0dce4b inc/Module/Install/Admin/Find.pm
SHA1 cbd7f1b8b1305e5e1e021d98c4ccd426abee636a inc/Module/Install/Admin/Include.pm
SHA1 8b56c5ab23aff87d3f26ead0413ed76a27fbde6b inc/Module/Install/Admin/Makefile.pm
SHA1 ef1e5c0c4b93909b88db1858a8dc1c3670917c00 inc/Module/Install/Admin/Manifest.pm
SHA1 af2d9b16870213c343692025d8467ae7f98778f1 inc/Module/Install/Admin/Metadata.pm
SHA1 b09e0ac66677f2d146b0e461665b5e5f26478bcd inc/Module/Install/Admin/ScanDeps.pm
SHA1 74113163f6c42f84e0b18df6a8d2dc15ac21dc30 inc/Module/Install/Admin/WriteAll.pm
SHA1 63e1527b13cdc1b5271e7215852df6d3de12adc4 inc/Module/Install/AutoInstall.pm
SHA1 cf824f6553c0c1ca740b8070238ccb1b09f12c34 inc/Module/Install/Base.pm
SHA1 77f87d329ab629d75df7e5d3a23e5641f53f6652 inc/Module/Install/Bundle.pm
SHA1 3d9dd511eab36b1a1ef67473c9831f0a8edd0c05 inc/Module/Install/Can.pm
SHA1 c7f612458ae4a2fababab8806d21ed31876aae4f inc/Module/Install/Compiler.pm
SHA1 6cd2a70d0b2ad1a63280c4b56f35f0be5579b721 inc/Module/Install/DSL.pm
SHA1 0bf8ecfd36d43df7f03832e8693146fdfca29821 inc/Module/Install/Deprecated.pm
SHA1 dc0fddf64d77872bef20939c87af5f8b77e1280f inc/Module/Install/External.pm
SHA1 bd1ef7ac4d4cc9f019c1ce2e56321b7e22fb3184 inc/Module/Install/Fetch.pm
SHA1 1dc51bed18c981159179e2570a5e939e388b31a8 inc/Module/Install/Include.pm
SHA1 253bd29a58ffd37e8c81b1905b05506311e254c3 inc/Module/Install/Inline.pm
SHA1 a28f105ac4a31e0e91691c1da699dd5021f34c39 inc/Module/Install/MakeMaker.pm
SHA1 8a60c0ee8ecb233aed0c180a959d5595d503690b inc/Module/Install/Makefile.pm
SHA1 3882d9c8be1397b93472f11beff898f6ff30224b inc/Module/Install/Metadata.pm
SHA1 47911f4ab8b32265e837017dc2be798161f8aaff inc/Module/Install/PAR.pm
SHA1 696e605f50d9c5710f69f5a80513ef3c908fe0b1 inc/Module/Install/Philosophy.pod
SHA1 e51d256f3c61dc968e1f3226d04c6fd06c3586d8 inc/Module/Install/RTx.pm
SHA1 5c589819986050dd79faf8572992a9790ae89f2e inc/Module/Install/RTx/Factory.pm
SHA1 dc972927565015ffbbaae806ff44634cae6fa1d2 inc/Module/Install/ReadmeFromPod.pm
SHA1 0ae795f0a9b6783872d393f92f9dc7173f7632e9 inc/Module/Install/Win32.pm
SHA1 2ad05d85780f32385e90fc76da59f635d453e29a inc/Module/Install/WriteAll.pm
SHA1 ec573ce8b2ad78c33cabd2c5db16d89544f0bde3 inc/Module/Install/Run.pm
SHA1 e3a659d39ea4dafc3710a699c3f6b1899b70fa54 inc/Module/Install/Scripts.pm
SHA1 8057872efd55c155d12f009cb190a81f7f775703 inc/Module/Install/Share.pm
SHA1 3ef36786817df816cca65bcae5e987591512aeeb inc/Module/Install/Win32.pm
SHA1 1349967ec3cd8c41a7717750ae23ede9824a2f39 inc/Module/Install/With.pm
SHA1 b7fc200ced09546b337e460a29379e4bd6927ca2 inc/Module/Install/WriteAll.pm
SHA1 957de860791a333fb9a77f0f7667779c43bce9b3 lib/RT/Extension/ReferenceIDoitObjects.pm
SHA1 4b73bb903ecf361c17a7f6be9998b9f8095f0693 po/de.po
SHA1 3987a51914e4ffa806ad31ce27fedd752468e3bf t/00-load.t
Expand All @@ -64,7 +87,7 @@ SHA1 640935336dc1123c0069bcf5432bcaedc2cf22d3 t/pod.t
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlBKDO4ACgkQWFkxZRfLwXK1pQCg1K7/2iZaqbiCyvLzyqr33oJ9
zxIAniq77AkUa/DKdZZaVCJ4fLiZ5k4Q
=lJhg
iEYEARECAAYFAlD0CwUACgkQWFkxZRfLwXLuMgCglhtX6rJEK0LGjqKb5MkfCrNU
xbsAnRBEuiffg2rodUzKYwrFjtLlqtXw
=9BpY
-----END PGP SIGNATURE-----
21 changes: 9 additions & 12 deletions html/Callbacks/ReferenceIdoitObjects/Elements/Tabs/Privileged
View file
Expand Up @@ -11,19 +11,16 @@

my $request_path = $HTML::Mason::Commands::r->path_info;

my $query_string = sub {
my %args = @_;
my $u = URI->new();
$u->query_form(%args);
return $u->query;
};

if ( $request_path =~ m{^/Ticket/} ) {
my $tabs = PageMenu();
$tabs->child(
'refidoitobj' => title => loc('Referenced i-doit objects'),
path => "/Ticket/ModifyIDoitObjects.html?" . $query_string->( %{ $m->request_args } )
);
if ( ( $m->request_args->{'id'} || '' ) =~ /^(\d+)$/ ) {
my $id = $1;

my $tabs = PageMenu();
$tabs->child(
'refidoitobj' => title => loc('Referenced i-doit objects'),
path => "/Ticket/ModifyIDoitObjects.html?id=" . $id
);
}
}

</%INIT>
Expand Down

0 comments on commit 4e8fdec

Please sign in to comment.