New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow loading prompt in some repositories #132

Closed
martinpelikan opened this Issue Oct 25, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@martinpelikan
Contributor

martinpelikan commented Oct 25, 2015

I just checked out https://github.com/ryanoasis/nerd-fonts because of the discussion I saw in #95. (tl;dr: I'm using urxvt and the fallback method doesn't seem to be an option, nerd-fonts provides patched fonts for Ubuntu mono which I like).

Anyway, the prompt takes somewhere between half a second to a second to load. Even when I remove all the segments, this is the case which is a bit strange. My suspicions are:

  1. Logic for non-rendered segments is still being executed, which is wasteful
  2. Something in the logic for the VCS prompt scales with repository size (nerd-fonts is 1.8GB), which other themes (such as agnoster) do not do.

Will follow up with any findings I might make, but hopefully this helps if anyone else looks into it!

@dritter

This comment has been minimized.

Show comment
Hide comment
@dritter

dritter Oct 26, 2015

Collaborator

The prompt in my nerd-fonts checkout is as fast as in other repositories.. It is slower than in non-VCS folders, but that is normal (VCS_INFO does a lot).

For comparison, my segments are:
status os_icon load context dir vcs symfony2_version time

Collaborator

dritter commented Oct 26, 2015

The prompt in my nerd-fonts checkout is as fast as in other repositories.. It is slower than in non-VCS folders, but that is normal (VCS_INFO does a lot).

For comparison, my segments are:
status os_icon load context dir vcs symfony2_version time

@dritter

This comment has been minimized.

Show comment
Hide comment
@dritter

dritter Nov 11, 2015

Collaborator

@martinpelikan Anything new here? Maybe it is an issue from a ZSH framework you use.. Could you retest it with plain ZSH?

Collaborator

dritter commented Nov 11, 2015

@martinpelikan Anything new here? Maybe it is an issue from a ZSH framework you use.. Could you retest it with plain ZSH?

@dritter

This comment has been minimized.

Show comment
Hide comment
@dritter

dritter Nov 18, 2015

Collaborator

Another approach could be to render the vcs segment asynchronously like described in this article. This technique is also used by the pure zsh theme. This might be a long-term goal.

Collaborator

dritter commented Nov 18, 2015

Another approach could be to render the vcs segment asynchronously like described in this article. This technique is also used by the pure zsh theme. This might be a long-term goal.

@bhilburn

This comment has been minimized.

Show comment
Hide comment
@bhilburn

bhilburn Dec 13, 2015

Owner

@martinpelikan - Any updates, here? If not, can we close?

Owner

bhilburn commented Dec 13, 2015

@martinpelikan - Any updates, here? If not, can we close?

@martinpelikan

This comment has been minimized.

Show comment
Hide comment
@martinpelikan

martinpelikan Dec 13, 2015

Contributor

I haven't had much time to try and reproduce this, and haven't encountered it since opening this issue. Closing this until I have something more concrete to work with. (Also, non-blocking prompts look pretty interesting!)

Contributor

martinpelikan commented Dec 13, 2015

I haven't had much time to try and reproduce this, and haven't encountered it since opening this issue. Closing this until I have something more concrete to work with. (Also, non-blocking prompts look pretty interesting!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment