Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use ip command for VPN segment - fix #1125 #1126
Thank you so much for opening a PR for P9k! Many of our best features and segments have come from the community, and we are excited to see your contribution.
To help you make the best PR, here are some guidelines:
Once you have submitted your PR, P9k core contributors will review the code and work with you to get it merged. During this process, we might request changes to your code and discuss different ways of doing things. This is all part of the open source process, and our goal is to help you create the best contribution possible for P9k
Please follow this template for creating your PR:
Please make the title of your PR descriptive! If appropriate, please prefix the title with one of these tags:
Please describe the contribution your PR makes! Screenshots are especially helpful, here, if it's a new segment.
If your PR is addressing an issue, please reference the Issue number here.
Is there something in your PR you're not sure about or need help with? Is there a particular piece of code you would like feedback on? Let us know here!
Hi @Shini31 ,
I made some changes to your code ninja-style. The code now runs without externals and is now the same for checking for VPN, as well as parsing public and internal IPs. Could you double check if everything still works for you and report here back? That would be awesome.