Updated the test case, ensured test passage. #5

merged 1 commit into from Oct 12, 2012


None yet
2 participants

michaeljbishop commented Oct 10, 2012

I don't know if you had good reasons for not overriding any of the methods in BasicObject, but it did break the test. Myself, I prefer overriding those because it allows me to better treat the resulting object as if it were the real thing.

@michaeljbishop michaeljbishop Updated the test case, ensured test passage.
The test case needed to be updated for the latest RSpec version.
The tests were failing because Future and Object didn't remove their
methods if they inherited BasicObject. In that case, equal? wasn't
overridden as well as the equality operators and any RSpec test that
compared the promise result to another result using '==' would fail.

bhuga merged commit ae70124 into bhuga:master Oct 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment