New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Save - Yes/No dialog and editing a Personal commentary #105

Closed
gholmlund opened this Issue May 31, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@gholmlund
Contributor

gholmlund commented May 31, 2017

There is inconsistency between the "plain" and "HTML" windows and editing a personal commentary. When editing a "plain" Personal commentary and using the "Save" icon, nothing else happens. When editing a "HTML" Personal commentary and using the "Save" icon, the "Save changed text" dialog appears. It should not appear when the "Save" icon is used. Also, after saving, the dialog reappears (recursively) and only goes away when using the Close ("x") or "No" on the dialog.

Desired behavior

  1. "Save changed text" dialog only appears when changing to another reference, not when "Save" icon is explicitly used.
  2. Using "Yes" should cause the dialog to close.

Note: Closing the Personal window cause another dialog to appear with Yes, No, Cancel. This works correctly.

gholmlund added a commit that referenced this issue May 31, 2017

Fix bug #105, Problem with Save - Yes/No dialog
  and editing a Personal commentary

gholmlund added a commit that referenced this issue May 31, 2017

Fix bug #105, Problem with Save - Yes/No dialog
  and editing a Personal commentary

@gholmlund gholmlund self-assigned this May 31, 2017

@gholmlund gholmlund closed this May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment