Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Save - Yes/No dialog and editing a Personal commentary #105

Closed
gholmlund opened this issue May 31, 2017 · 0 comments
Closed
Assignees
Labels
component: Frontend resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG

Comments

@gholmlund
Copy link
Contributor

There is inconsistency between the "plain" and "HTML" windows and editing a personal commentary. When editing a "plain" Personal commentary and using the "Save" icon, nothing else happens. When editing a "HTML" Personal commentary and using the "Save" icon, the "Save changed text" dialog appears. It should not appear when the "Save" icon is used. Also, after saving, the dialog reappears (recursively) and only goes away when using the Close ("x") or "No" on the dialog.

Desired behavior

  1. "Save changed text" dialog only appears when changing to another reference, not when "Save" icon is explicitly used.
  2. Using "Yes" should cause the dialog to close.

Note: Closing the Personal window cause another dialog to appear with Yes, No, Cancel. This works correctly.

gholmlund pushed a commit that referenced this issue May 31, 2017
  and editing a Personal commentary
gholmlund pushed a commit that referenced this issue May 31, 2017
  and editing a Personal commentary
@gholmlund gholmlund self-assigned this May 31, 2017
@gholmlund gholmlund added the resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. label May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Frontend resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG
Development

No branches or pull requests

2 participants