New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mag not always working with Hebrew / Strong #132

Closed
jcornuz opened this Issue Feb 27, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@jcornuz

jcornuz commented Feb 27, 2018

Hello,

This is with the Open Scripture Hebrew Bible and the Strong real Hebrew modules.

Some words work as expected (hovering over with the mouse displays the strong entry in the mag) while others don't (the mag is stuck with the previous entry). In Jonah 1,1 for exemple, the first and last words don't work; in 1.2 it is some words in the middle of the verse that fail.

I have checked with xiphos (which displays the strong numbers embedded in the text) and there are definitely numbers associated with each of the words.
Toggling cantillation, voyel points, changing display style, switching to "standard strong"... none of these make a difference.
This is on Fedora 27, if that makes any difference.

I hope this helps. Many thanks for BibleTime, it is good to see such a project carry on through the years (I remember using BT in my Bible classes in.... 1999!)

Joel

@gholmlund gholmlund added the type: BUG label Mar 3, 2018

@gholmlund gholmlund self-assigned this Mar 3, 2018

@gholmlund

This comment has been minimized.

Contributor

gholmlund commented Mar 3, 2018

The following is extracted from Jonah 1:1. There are "?" where the Hebrew chars are. The first and last words have different html formatting that the others. The others have the Strongs reference in the span surrounding the word. The first and last have child spans for the words, so the Strongs reference is in the parent node of the word.

Updated: Adding the html here does not appear right, so I removed it and just look at the description above.

@gholmlund

This comment has been minimized.

Contributor

gholmlund commented Mar 3, 2018

I modified the javascript code that gets the lemma, etc. from the mouse movements. If the current node does not have any attributes, check the parent node for attributes and use them.

Change made for master and stable-2.11

@jcornuz

This comment has been minimized.

jcornuz commented Mar 4, 2018

@jaakristioja jaakristioja added this to the 2.11.2 milestone Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment