Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some greek dictionary modules don't work in magnifier #52

Closed
HinzundKunz opened this issue Mar 1, 2016 · 4 comments
Closed

Some greek dictionary modules don't work in magnifier #52

HinzundKunz opened this issue Mar 1, 2016 · 4 comments

Comments

@HinzundKunz
Copy link

@HinzundKunz HinzundKunz commented Mar 1, 2016

MLStrong, Dodson, RealGreek and Abott-Smith don't work in the magnifier when set as default dictionary. I tried the same settings in xiphos, and they didn't work there either, so it seems to be a problem with the modules...

@jaakristioja
Copy link
Member

@jaakristioja jaakristioja commented Oct 5, 2016

... or with Sword.

@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Oct 26, 2016

Inverse Lexicons also don't work (InvStrongsRealGreek, InvStrongsRealHebrew).

I don't see any information in the *.conf file for these modules to be able to distinguish modules that will work for Strong's numbers lookup.

@jaakristioja jaakristioja modified the milestones: 2.12.0, 2.11.0 Dec 17, 2016
@jaakristioja jaakristioja modified the milestones: 2.11.1, 2.12.0 Feb 3, 2017
@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Sep 24, 2017

I debugged using the ESV2011 at Revelation 1:1 using the word "angel". The strongs reference requested for "angel" is "G32". In Rendering::decodeStrongs (btinforendering.cpp) we remove the "G" and do setKey for "32". This works for StrongsGreek, StrongsRealGreek, and AbbotSmithStrongs. It does not work for MLStrong and Dodson.

If you open all these modules in a window and look for that strongs entry you will find that the entry for StrongsGreek, StrongsRealGreek, and AbbotSmithStrings is "00032". The entry for MLStrong and Dodson is "G0032".

Even if I do a setKey of "G32", the MLStrong and Dodson won't work with that. They need "G0032".

So, in this example I have "G32", "00032", and "G0032". Are there any standards for strongs keys?

gholmlund added a commit that referenced this issue Sep 28, 2017
gholmlund added a commit that referenced this issue Sep 28, 2017
@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Sep 28, 2017

added functionality to detect the leading char and number of digits used by the lexicon. Keys to be searched for to display in the MAG window are reformatted to be consistent with the lexicon module.

Also, filter the entries in the config dialog lexicon combobox to only show lexicons with valid Strong's references as their key. This eliminates the inverse lexicons.

@gholmlund gholmlund closed this Sep 28, 2017
@gholmlund gholmlund self-assigned this Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.