New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some greek dictionary modules don't work in magnifier #52

Closed
HinzundKunz opened this Issue Mar 1, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@HinzundKunz

HinzundKunz commented Mar 1, 2016

MLStrong, Dodson, RealGreek and Abott-Smith don't work in the magnifier when set as default dictionary. I tried the same settings in xiphos, and they didn't work there either, so it seems to be a problem with the modules...

@jaakristioja

This comment has been minimized.

Show comment
Hide comment
@jaakristioja

jaakristioja Oct 5, 2016

Member

... or with Sword.

Member

jaakristioja commented Oct 5, 2016

... or with Sword.

@gholmlund

This comment has been minimized.

Show comment
Hide comment
@gholmlund

gholmlund Oct 26, 2016

Contributor

Inverse Lexicons also don't work (InvStrongsRealGreek, InvStrongsRealHebrew).

I don't see any information in the *.conf file for these modules to be able to distinguish modules that will work for Strong's numbers lookup.

Contributor

gholmlund commented Oct 26, 2016

Inverse Lexicons also don't work (InvStrongsRealGreek, InvStrongsRealHebrew).

I don't see any information in the *.conf file for these modules to be able to distinguish modules that will work for Strong's numbers lookup.

@gholmlund

This comment has been minimized.

Show comment
Hide comment
@gholmlund

gholmlund Sep 24, 2017

Contributor

I debugged using the ESV2011 at Revelation 1:1 using the word "angel". The strongs reference requested for "angel" is "G32". In Rendering::decodeStrongs (btinforendering.cpp) we remove the "G" and do setKey for "32". This works for StrongsGreek, StrongsRealGreek, and AbbotSmithStrongs. It does not work for MLStrong and Dodson.

If you open all these modules in a window and look for that strongs entry you will find that the entry for StrongsGreek, StrongsRealGreek, and AbbotSmithStrings is "00032". The entry for MLStrong and Dodson is "G0032".

Even if I do a setKey of "G32", the MLStrong and Dodson won't work with that. They need "G0032".

So, in this example I have "G32", "00032", and "G0032". Are there any standards for strongs keys?

Contributor

gholmlund commented Sep 24, 2017

I debugged using the ESV2011 at Revelation 1:1 using the word "angel". The strongs reference requested for "angel" is "G32". In Rendering::decodeStrongs (btinforendering.cpp) we remove the "G" and do setKey for "32". This works for StrongsGreek, StrongsRealGreek, and AbbotSmithStrongs. It does not work for MLStrong and Dodson.

If you open all these modules in a window and look for that strongs entry you will find that the entry for StrongsGreek, StrongsRealGreek, and AbbotSmithStrings is "00032". The entry for MLStrong and Dodson is "G0032".

Even if I do a setKey of "G32", the MLStrong and Dodson won't work with that. They need "G0032".

So, in this example I have "G32", "00032", and "G0032". Are there any standards for strongs keys?

@gholmlund

This comment has been minimized.

Show comment
Hide comment
@gholmlund

gholmlund Sep 28, 2017

Contributor

added functionality to detect the leading char and number of digits used by the lexicon. Keys to be searched for to display in the MAG window are reformatted to be consistent with the lexicon module.

Also, filter the entries in the config dialog lexicon combobox to only show lexicons with valid Strong's references as their key. This eliminates the inverse lexicons.

Contributor

gholmlund commented Sep 28, 2017

added functionality to detect the leading char and number of digits used by the lexicon. Keys to be searched for to display in the MAG window are reformatted to be consistent with the lexicon module.

Also, filter the entries in the config dialog lexicon combobox to only show lexicons with valid Strong's references as their key. This eliminates the inverse lexicons.

@gholmlund gholmlund closed this Sep 28, 2017

@gholmlund gholmlund self-assigned this Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment