Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt "More Info..." tab is blank #92

Closed
bontibon opened this issue Jan 25, 2017 · 6 comments
Closed

Qt "More Info..." tab is blank #92

bontibon opened this issue Jan 25, 2017 · 6 comments

Comments

@bontibon
Copy link

@bontibon bontibon commented Jan 25, 2017

Version: d755be9
Qt version: 5.7.1

To reproduce: Help -> About BibleTime -> Qt -> More Info...
The view is blank (completely white):

image

@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Jan 25, 2017

I note that the version shown is the master branch HEAD. I tried this and stable-2.11 using ubuntu 16.10 and Qt 5.7.1. I could not reproduce this problem.

@jaakristioja
Copy link
Member

@jaakristioja jaakristioja commented Jan 25, 2017

I'm unable to reproduce with the same revision on Gentoo Linux using Qt 5.7.1 as well.

@bontibon
Copy link
Author

@bontibon bontibon commented Jan 25, 2017

I'm on Arch Linux.

In doing some debugging, it appears that BtAboutDialog::linkClicked does not get called for that link, but does for all others in the about dialog.

@jaakristioja
Copy link
Member

@jaakristioja jaakristioja commented Jan 26, 2017

Please disregard my comment about not able to reproduce. I misunderstood the issue late last night. I can now reproduce.

Clicking on the "More info..." link should open a new "About Qt" dialog window instead of changing the contents of that HTML view widget. Instead it seems to switch the HTML view to a blank page. Maybe related to the switch from QWebView to QWebEngineView. It seems that the BtAboutDialog::linkClicked slot does not get called at all.

@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Jan 27, 2017

QWebEnginePage only works with links beginning with http, https, and ftp. We used a url of "about:qt".
https://bugreports.qt.io/browse/QTBUG-50922

gholmlund added a commit that referenced this issue Jan 27, 2017
gholmlund added a commit that referenced this issue Jan 27, 2017
@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Jan 27, 2017

QWebKit and QWebEngine were both broken for different reasons. Fixed and tested with Qt 5.5, 5.6, 5.7, and 5.8. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.