Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove ManufacturersAmplifierModelName (again) #236

Conversation

@robertoostenveld
Copy link
Collaborator

robertoostenveld commented May 23, 2019

- this was discussed in the past and supposed to be already removed in version https://github.com/bids-standard/bids-specification/blob/master/src/CHANGES.md#111 but apparently slipped through
- it is documented in the text properly, where it states "Note that if EEG is recorded with a separate amplifier, it should be stored separately under a new /eeg data type"
Copy link
Collaborator

dorahermes left a comment

lgtm

@choldgraf choldgraf merged commit 307d1bb into bids-standard:master May 23, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented May 23, 2019

to confirmations and this LGTM so merging away!

franklin-feingold added a commit that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.