Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Find npm requirements file in Circle #336

merged 2 commits into from Sep 24, 2019


Copy link

franklin-feingold commented Sep 19, 2019


tested on CircleCI and the directory is correct to pull our style guides

note: the other failed tests appear to be from the quick succession of merged PRs (parallel running)

update 9/18
@@ -90,7 +90,7 @@ jobs:
name: get remark styles
command: |
cd ~
cat ~/build/npm-requirements.txt | xargs npm install
cat ~/project/npm-requirements.txt | xargs npm install

This comment has been minimized.

Copy link

effigies Sep 19, 2019


It doesn't look like there will be anything in ~/project? This doesn't make much sense to me.

This comment has been minimized.

Copy link

franklin-feingold Sep 19, 2019

Author Collaborator

I just checked running the ssh on 1326 and there is a project folder. This folder is created at checkout

This comment has been minimized.

Copy link

sappelhoff Sep 19, 2019


~/project is the default CircleCI working directory, search for it (ctrl+f) on this page:

if you tested this and it works, this seems fine to me

@effigies effigies changed the title [INFRA] fix circle npm requirements file [INFRA] Find npm requirements file in Circle Sep 24, 2019
@franklin-feingold franklin-feingold merged commit d39c13f into bids-standard:master Sep 24, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
ci/circleci: build_docs Your tests passed on CircleCI!
ci/circleci: build_docs artifact Link to 0/home/circleci/project/site/01-introduction.html
ci/circleci: linkchecker Your tests passed on CircleCI!
franklin-feingold added a commit that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.