Add support for Enums to filename sniff #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our file name sniff to account for enums correctly.
Enums should follow the same rules as interfaces, classes, and traits:
enum-This PR also remove some template checks that came from the original Sniff, but are not required for our purposes.
Testing steps
Create a file called
enum-my-enum.php:Run
There should be no errors.
Then try:
Run
./vendor/bin/phpcs .after every change.If the filename isn't exactly the lower-kebab case name of the enum, prefixed with
enum-, PHPCS should error.Types of changes (if applicable):
Checklist (if applicable):