Replace Squiz.Commenting.FunctionComment with new Sniff
#192
+3,629
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
Squiz.Commenting.FunctionCommentSniff with extended version under theBigBiteDocsnamespace.Behaviourally, this new Sniff suggests
intandboolas the correct type hints when doing type checking, rather thanintegerandbooleanas in theSquizSniff, to adhere to Big Bite's coding standard more correctly.We used to exclude several error codes from the
SquizSniff, which we no longer do, now that we've introduced our version of the Sniff.Because this is likely to result in lots of instances of the
ParamCommentNotCapitalandParamCommentFullStoperror codes, this PR also adds fixers for this, to make the adoption process more straightforward.Types of changes (if applicable):
Checklist (if applicable):
composer run all-checks.