Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement new UI styles #44

Merged
merged 10 commits into from Sep 15, 2014

Conversation

Projects
None yet
2 participants
@GaryDeng
Copy link
Contributor

GaryDeng commented Aug 1, 2014

No description provided.

GaryDeng added some commits Jul 15, 2014

Merge branch 'add-videoaudio-settings-view' of https://github.com/Sen…
…ecaCDOT-BigBlueButton/bbb-air-client into edit-styles

Conflicts:
	src/Default.css
	src/Main.mxml
	src/assets/res/drawable-xxxhdpi/SwapCamera_up.png
	src/locale/en_US/resources.properties
	src/org/bigbluebutton/view/navigation/pages/chatrooms/ChatRoomsViewMediator.as
	src/org/bigbluebutton/view/navigation/pages/participants/ParticipantItemRenderer.mxml
	src/org/bigbluebutton/view/navigation/pages/participants/ParticipantsViewMediator.as
	src/org/bigbluebutton/view/navigation/pages/profile/ProfileViewBase.mxml
	src/org/bigbluebutton/view/navigation/pages/userdetails/UserDetaisViewBase.mxml
	src/org/bigbluebutton/view/navigation/pages/videochat/VideoChatViewBase.mxml

@Adam-Sharpe Adam-Sharpe referenced this pull request Aug 28, 2014

Open

Lock settings #48

userSession.userList.listenOnlyChange(msg.userId, msg.listenOnly);
//It seems that listenOnly keeps to be true
//Temp solution to set listenOnly to false when user drop listen only mode.
var listenOnly:Boolean = userSession.userList.me.listenOnly? false : true;

This comment has been minimized.

@capilkey

capilkey Sep 4, 2014

Member

I think you can use "!userSession.userList.me.listenOnly" instead of the in-line if

return shareMicBtn;
}

public function get shareMicBtnLabel():String

This comment has been minimized.

@capilkey

capilkey Sep 4, 2014

Member

Why do you need a separate getter for the label property?

}
else
{
FlexGlobals.topLevelApplication.pageName.text = ResourceManager.getInstance().getString('resources', 'chat.title') + "s (" + (dataProvider.length-1) + ")";

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

Just adding an "s" when there are multiple rooms isn't applicable if the client is using a language other than English

handIcon.includeInLayout = true;
handIcon.visible = obj.raiseHand;
presentationIcon.visible = presentationIcon.includeInLayout = profileIcon.includeInLayout = profileIcon.visible = false;
}

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

The raise hand functionality was recently changed in 0.9 so that anyone can raise their hand

<s:Image id="micIcon" styleName="iconStyle micIconStyle" height="100%"/>
<s:Image id="micOffIcon" styleName="iconStyle micOffIconStyle" visible="false" height="100%"/>
<s:Image id="listenOnlyIcon" styleName="iconStyle listenOnlyIconStyle" visible="false" height="100%"/>
</s:Group>

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

I think this Group can be removed

@@ -4,75 +4,49 @@
xmlns:mx="library://ns.adobe.com/flex/mx"
xmlns:view="org.bigbluebutton.core.view.*"
xmlns:userdetails="org.bigbluebutton.view.navigation.pages.userdetails.*"
styleName="viewStyle"
styleName="userDetailviewStyle"

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

The styleName should be "userDetailViewStyle"

</s:VGroup>
</s:VGroup>
</s:Scroller>
<s:VGroup width="100%" height="100%" horizontalAlign="center">

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

The VGroup needs to have a Scroller added to it because you can't see everything on a smaller screen.

</s:Scroller>
<s:VGroup width="100%" height="100%" horizontalAlign="center">
<s:Label width="90%" styleName="contentFontSize userSettingsStyle" text="{resourceManager.getString('resources', 'profile.participant')}"/>
<s:Button id="userName0" width="90%" buttonMode="false" styleName="userSettingsButtonStyle userSettingsUserNameStyle contentFontSize"/>

This comment has been minimized.

@capilkey

capilkey Sep 5, 2014

Member

I can still click on my name in the debugger and it shows the click animation like all of the other buttons.

GaryDeng added some commits Sep 9, 2014

capilkey added a commit that referenced this pull request Sep 15, 2014

@capilkey capilkey merged commit d2b0d52 into bigbluebutton:master Sep 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.