Skip to content

fix: Remove Grace Period for locked user in chat #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tainan404
Copy link
Member

What does this PR do?

This PR removes the grace period for locked users and remove the behaviour of eject the locked users who sent chat messages (because there might be delayed messages sent between changing the lock setting)

@antobinary antobinary added this to the Release 2.4 milestone Dec 7, 2021
@antobinary antobinary requested a review from zhem0004 December 7, 2021 20:50
Copy link
Contributor

@zhem0004 zhem0004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently has a mistake, in case if statement evaluates to false, we return Unit. But you need add "else {state}" to return the unmodified state, that way if permission is failed no changes will be applied.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@zhem0004 zhem0004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very literally, but it all works.

@antobinary antobinary merged commit b41f895 into bigbluebutton:v2.4.x-release Jan 5, 2022
@antobinary antobinary changed the title Remove Grace Period for locked user in chat refactor: Remove Grace Period for locked user in chat Jan 12, 2022
@antobinary antobinary changed the title refactor: Remove Grace Period for locked user in chat fix: Remove Grace Period for locked user in chat Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants