Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove inner html #15067

Merged
merged 2 commits into from May 25, 2022

Conversation

Tainan404
Copy link
Member

What does this PR do?

This PR has as goal improve the bbb string parse capabilities and improve the aria notification.

Changes:

  • Add a new aria alert component improving the flow of the notifications adding a queue and using the React good practices to DOM manipulation.
  • Centralize the escape/stripHtml functions to avoid code duplication and side-effects behaviors.
  • Remove unecessary uses of the innerHTML in the client.

Motivation

Make BBB string manipulation and aria notifications easy.

@github-actions
Copy link

This pull request has conflicts
Please resolve those so we can review the pull request.
Thanks.

@ramonlsouza ramonlsouza added this to the Release 2.5 milestone May 25, 2022
@ramonlsouza ramonlsouza changed the title Remove inner html refactor: Remove inner html May 25, 2022
@ramonlsouza ramonlsouza merged commit 4e96fc5 into bigbluebutton:v2.5.x-release May 25, 2022
2 checks passed
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants