Fix for safari and ios specific code #4239
Conversation
| @@ -1,5 +1,5 @@ | |||
| <head> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | |||
There was a problem hiding this comment.
Just curious - this should prevent the application from zooming in Safari on iOS, right?
Does it work?
As far as I know Apple started ignoring these properties starting from iOS 10.
| flex: 1; | ||
| } | ||
|
|
||
| .presentationTransitions { |
There was a problem hiding this comment.
It looks like this class is not used anywhere.
| width: 100%; | ||
| height: 100%; | ||
| max-width: 100%; | ||
| max-height: 100%; |
There was a problem hiding this comment.
... why did you remove the 4 lines above?
| width: 100%; | ||
| height: 100%; | ||
| display: flex; |
There was a problem hiding this comment.
A lot of the styles in this file were changed recently, since we switched from pure CSS way of scaling the presentation. Now it's a JavaScript-controlled wrapper and then CSS scaling inside.
Tested the latest - everything is working perfectly in Safari for me (Safari 11).
But maybe I don't know about all the cases that you were trying to fix here.
There was a problem hiding this comment.
I've removed those changes in favor of the new styles for the presentations, I also tested in safari, and it seems to work :)
gcampes
force-pushed
the
2x-ios-webrtc
branch
from
18bd288
to
707f6f1
Compare
To test on the iOS app
Download Testflight on your iOS device, and select
redeem. You should have received an email invitation to Apple's Testflight which contains instructions and the code you should redeem to install the app on the device. Once you insert the code and proceed with the instructions you will be prompted to install the app on the device.