Reduce "Connecting to Echotest" waiting time by 4/8 seconds #9084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one of the most annoying things about breakout rooms is that the users have to do the echo test again. So they have to wait 7 to 12 seconds again (for most typical bbb configurations) just for the echo test to connect. This change reduces the iceCheckingTimeout from 5 seconds to 1 second, which is still way more than enough unless there is a configuration or network load issue. Depending on network of the used client, this change saves the user between 4 to 8 seconds for every time they activate audio playback or microphone. The original 5 seconds timeout is not part of the official sip.js library but instead was added in #2877
|
Seems to be related to mconf#233 |
|
@basisbit Thanks for the pull request. We're going to try it and let you know how it works. |
This was referenced Apr 15, 2020
basisbit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change
iceCheckingTimeoutfrom 5 seconds to 1 second in/usr/share/meteor/bundle/programs/web.browser/app/compatibility/sip.jsAdditional Notes
One of the most annoying things about breakout rooms is that the users have to do the echo test again. So they have to wait 7 to 12 seconds again every time (for typical bbb configurations) just for the echo test to connect. This PR reduces the iceCheckingTimeout from 5 seconds to 1 second, which is still way more than enough for finding candidates to connect to the freeswitch server unless there is a configuration or network load issue. Depending on network of the used client, this change saves the user between 4 to 8 seconds for every time they activate audio playback or microphone.
The original 5 seconds timeout is a default of the official sip.js library and was added in #2877 to the bbb-custom sip.js . Documentation for this parameter in sip.js:
http://sipjs.com/api/0.7.0/ua_configuration_parameters/#icecheckingtimeout
This change was successfully tested with a group of 20 different users on different configurations on different networks in Germany on a couple of private bbb default installs and also on a .rna1_blindsidenetworks_com instance.