Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freeswitch package names for languages with uppercase characters in the path #119

Merged

Conversation

lexuzieel
Copy link
Contributor

Certain freeswitch sounds have uppercase letters in their path, for example ru/RU and pt/BR;
This makes it impossible to use them by setting a language in .env:

SOUNDS_LANGUAGE=ru-RU-elena

produces correct directory path:

/usr/share/freeswitch/sounds/ru/RU/elena

however, it cannot install this package in entrypoint.sh, since the package name becomes freeswitch-sounds-ru-RU-elena while it has to be lowercase (freeswitch-sounds-ru-ru-elena).

This PR fixes this by making package name always lowercase.

Always install using lowercase package name
@alangecker
Copy link
Collaborator

this looks good!
thanks for the PR! :)

@alangecker alangecker merged commit 09a47e9 into bigbluebutton:develop Jun 21, 2021
@alangecker alangecker mentioned this pull request Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants