Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): CHI-399 update lozenge colors #28

Merged
merged 4 commits into from Apr 22, 2019
Merged

fix(component): CHI-399 update lozenge colors #28

merged 4 commits into from Apr 22, 2019

Conversation

rtalvarez
Copy link
Member

@rtalvarez rtalvarez commented Apr 11, 2019

What?

https://jira.bigcommerce.com/browse/CHI-399

Updates the colors on some lozenges based on finalized designs

Testing done

  • Verified with design (Brian C)

Note for the curious

-> Why are we adding another blue color instead of using one from the palette?

From Brian:

we’re reserving the bright blue for “actions”… anytime we use that blue it should be clickable, or just clicked, hovered etc. that dark blue is in the sidebar nav… we’re thinking of it as our primary blue, but this is an instance where it’s just a notification and not actionable.

All these guidelines will be more widely available soon ™

@rtalvarez rtalvarez added the do not merge Don't merge this PR! label Apr 12, 2019
@rtalvarez rtalvarez removed the do not merge Don't merge this PR! label Apr 22, 2019
@rtalvarez rtalvarez merged commit e7132d3 into bigcommerce:master Apr 22, 2019
@rtalvarez rtalvarez deleted the lozenge-updates branch April 22, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants