Skip to content

Improvements: composer.json, coding style, PHPUnit and Travis CI #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 2, 2018
Merged

Improvements: composer.json, coding style, PHPUnit and Travis CI #240

merged 5 commits into from
Nov 2, 2018

Conversation

@kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Oct 12, 2018

This PR:

  • normalizes composer.json
  • removes unnecessary options from composer.json
  • adds PHP CS Fixer and fixes code with it to follow PSR2
  • upgrades PHPUnit to use v6/v7
  • updates Travis CI configuration (similar as here)

PascalZajac
PascalZajac approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@PascalZajac PascalZajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, Travis passes so seems safe. Nice work.

@bookernath bookernath merged commit e6f8446 into bigcommerce:master Nov 2, 2018
@kubawerlos kubawerlos deleted the improvements branch November 2, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PascalZajac PascalZajac PascalZajac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kubawerlos @PascalZajac @bookernath