Corrected branding, fixed broken tests, added test metrics, updated gemspec #26

Merged
merged 3 commits into from Nov 15, 2012

3 participants

@sgerrand
  • Changed BigCommerce references to Bigcommerce (branding)
  • Added test_files entry to gemspec
  • Added CI Reporter gem to gemspec for continuous integration
  • Removed rubygems references, as Bundler is being used
  • Fixed broken tests by adding require for Date stdlib class
  • Added legacy include lib file for people using BigCommerce namespace
  • Added version component constants
  • Added gitignore for Bundler gem packaging and install cruft
  • Added gitignore for CI Reporter output
  • Added autotest config file
Sasha Gerrand Corrected branding, fixed broken tests, added test metrics, updated g…
…emspec

* Changed BigCommerce references to Bigcommerce (branding)
* Added CI Reporter gem for continuous integration
* Removed rubygems references, as Bundler is being used
* Fixed broken tests by adding require for Date stdlib class
* Added legacy include lib file for people using BigCommerce namespace
* Added version component constants
* Added gitignore for Bundler gem packaging and install cruft
* Added gitignore for CI Reporter output
* Added autotest config file
8cbe399
@maetl maetl and 1 other commented on an outdated diff Nov 15, 2012
bigcommerce.gemspec
s.add_development_dependency("rspec", '~> 2.11')
+ s.authors = ["Bigcommerce"]
+ s.date = Time.now.strftime("%Y-%m-%d")
+ s.description = "Enables Ruby applications to communicate with the Bigcommerce API V2 (currently in beta trial)."
@maetl
maetl added a note Nov 15, 2012

We can remove “currently in beta trial” too.

Changing that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@maetl maetl and 1 other commented on an outdated diff Nov 15, 2012
lib/bigcommerce/version.rb
@@ -1,3 +1,6 @@
-module BigCommerce
- VERSION = "0.0.5"
+module Bigcommerce
+ MAJOR = 0 unless defined? Bigcommerce::MAJOR
+ MINOR = 0 unless defined? Bigcommerce::MINOR
+ PATCH = 6 unless defined? Bigcommerce::PATCH
+ VERSION = [MAJOR, MINOR, PATCH].join('.') unless defined? Bigcommerce::VERSION
@maetl
maetl added a note Nov 15, 2012

Is this a widespread convention? What are the advantages of doing it this way?

Not really. I've used it a lot in gems that have teams working on them. Separating out the semantic versioning components reminds people what means what.

That said, the components should probably not be constants. I'll fix that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@maetl

👍 I like.

@sgerrand

@sgerrand

@maetl

Thank you kindly.

@maetl maetl merged commit a9fc56b into bigcommerce:master Nov 15, 2012
@pedelman pedelman added the v0.x label Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment