STRF-4340 Set slick-next/prev to have top 50% #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
mjschock
approved these changes
Feb 15, 2018
Contributor
mjschock
left a comment
mjschock
left a comment
There was a problem hiding this comment.
LGTM - thanks @adamdyche !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The slick-next and slick-prev nav arrows for the carousel had a top spacing of 20% which on smaller screens pushed them very close to the top of the page, and not centered like it is on medium and large size devices. This fix, allows the nav arrows to be centered across all device screen sizes.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-4340
Screenshots (if appropriate)
ping @junedkazi @mjschock