fix(storefront): STRF-4804 Fix Store Logo image size for Amp Pages#1239
Merged
davidwrpayne merged 1 commit intobigcommerce:masterfrom May 18, 2018
Merged
fix(storefront): STRF-4804 Fix Store Logo image size for Amp Pages#1239davidwrpayne merged 1 commit intobigcommerce:masterfrom
davidwrpayne merged 1 commit intobigcommerce:masterfrom
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
mattolson
reviewed
May 17, 2018
CHANGELOG.md
Outdated
| - Fix for faceted search display. [#1225](https://github.com/bigcommerce/cornerstone/pull/1225) | ||
| - Fix for calls with empty files in Safari. [#1210](https://github.com/bigcommerce/cornerstone/pull/1210) | ||
|
|
||
| - Fix logo image dimensions on AMP pages. [#](https://github.com/bigcommerce/cornerstone/pull/) |
Contributor
There was a problem hiding this comment.
This needs to go into the Draft section and reference the PR number
mattolson
reviewed
May 17, 2018
| width="100" | ||
| height="50" | ||
| {{#if theme_settings.logo_size '===' 'original' }} | ||
| width="250" |
Contributor
There was a problem hiding this comment.
I understand that in this case we need to hard code some values because the actual image size is unknown. How do we choose the right values? Why was this changed to 250 from 100?
davidwrpayne
force-pushed
the
STRF-4804
branch
3 times, most recently
from
1e020cc to
c7f280d
Compare
mattolson
reviewed
May 18, 2018
Contributor
mattolson
left a comment
mattolson
left a comment
There was a problem hiding this comment.
Looks good. Couple of minor nits, and then please rebase.
CHANGELOG.md
Outdated
| - Fix for faceted search display. [#1225](https://github.com/bigcommerce/cornerstone/pull/1225) | ||
| - Fix for calls with empty files in Safari. [#1210](https://github.com/bigcommerce/cornerstone/pull/1210) | ||
|
|
||
| {{/if}} | ||
| alt="{{settings.store_logo.title}}"> | ||
| </amp-img> | ||
|
|
tpietsch
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Store logo is distorted on AMP pages on mobile or desktop. We were not respecting the logo settings when specified. There is still an issue however where if the image is larger than 250x50 then it doesn't get sized according to css properly.
below is an example of it still being incorrect for too large of a logo
Tickets / Documentation
Add links to any relevant tickets and documentation.
@mattolson @mjschock @Ubersmake