fix(storefront): STRF-4866 Fix missing quantity/selection for AMP product Page#1242
Merged
mattolson merged 1 commit intobigcommerce:masterfrom May 29, 2018
Merged
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
…es for simple products
davidwrpayne
pushed a commit
to davidwrpayne/cornerstone
that referenced
this pull request
May 31, 2018
davidwrpayne
pushed a commit
to davidwrpayne/cornerstone
that referenced
this pull request
May 31, 2018
davidwrpayne
pushed a commit
that referenced
this pull request
May 31, 2018
Revert "Merge pull request #1242 from davidwrpayne/STRF-4866"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is fixes the lack of a quantity selection on AMP pages for simple products. Previously we just had a link to the add to cart functionality. Now this uses the same product options logic. However since a simple product has no options it just doesn't show all the extra information.
Tickets / Documentation
Screenshots (if appropriate)
@mattolson @junedkazi @mjschock @bigcommerce/storefront-team