Avoid undefined context in WishList instance#1247
Merged
mattolson merged 1 commit intobigcommerce:masterfrom May 29, 2018
jbruni:fix-undefined-context
Merged
Avoid undefined context in WishList instance#1247mattolson merged 1 commit intobigcommerce:masterfrom jbruni:fix-undefined-context
mattolson merged 1 commit intobigcommerce:masterfrom
jbruni:fix-undefined-context
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
Contributor
Author
|
If the issue is difficult to understand, please let me know. I can record a short video showing what is expected, and what happens instead. |
Contributor
|
@jbruni Thanks for the bug fix, much appreciated. Can you add a quick entry to the changelog? We'll get this into the next point release. |
mattolson
approved these changes
May 29, 2018
Contributor
mattolson
left a comment
mattolson
left a comment
There was a problem hiding this comment.
Actually, don't worry about it, we'll follow up with a changelog entry. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The value of
this.contextisundefinedwithin WishList class instance, in the product and account pages. The classconstructorexpects acontextparameter, but no parameter is provided when the instance is created from "product-details.js" and "account.js".This has no side-effect when no customization is made to the theme. But any customization will expect
this.contextto have thecontextdata, rather thanundefined.Tickets / Documentation
I have reported it here, but it seems it has been ignored or not understood:
Thank you.