Fix arrow placement on currency selector dropdown#1267
Merged
junedkazi merged 1 commit intobigcommerce:masterfrom Jun 15, 2018
sacr3dc0w:currency-dropdown
Merged
Fix arrow placement on currency selector dropdown#1267junedkazi merged 1 commit intobigcommerce:masterfrom sacr3dc0w:currency-dropdown
junedkazi merged 1 commit intobigcommerce:masterfrom
sacr3dc0w:currency-dropdown
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
Contributor
|
@sacr3dc0w can you also share mobile views screens to make sure it works fine across all sizes. |
Contributor
|
time to rebase this PR |
Contributor
Author
|
@junedkazi The arrow disappears on small viewports (<800px). I couldn't locate where this rule occurs, though. currency dropdown closed |
junedkazi
approved these changes
Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The arrow on the currency selector dropdown is left aligned when it needs to be right aligned.
Documentation
#1254
Images
Before
After