From 9fb2af92bf3945b126e4baf01f2e0e814d0f5943 Mon Sep 17 00:00:00 2001 From: J Bruni Date: Tue, 26 Jun 2018 02:52:29 -0300 Subject: [PATCH] Fix Webpack 4 DefinePlugin config --- CHANGELOG.md | 1 + webpack.dev.js | 2 +- webpack.prod.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 620e12bdc1..54d55a804f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Draft - Fix wishlist dropdown background color bleeding out of container [#1283](https://github.com/bigcommerce/cornerstone/pull/1283) - Fix indefinite load spinner for products without an image in order history. [#1284](https://github.com/bigcommerce/cornerstone/pull/1284) +- Fix Webpack DefinePlugin configuration. [#1286](https://github.com/bigcommerce/cornerstone/pull/1286) ## 2.2.0 (2018-06-22) - Fix quantity edit on Simple Product AMP pages. [#1257](https://github.com/bigcommerce/cornerstone/pull/1257) diff --git a/webpack.dev.js b/webpack.dev.js index ca419d16d8..3e9e5d1356 100644 --- a/webpack.dev.js +++ b/webpack.dev.js @@ -7,7 +7,7 @@ module.exports = merge(commonConfig, { devtool: 'source-map', plugins: [ new webpack.DefinePlugin({ - 'process.env.NODE_ENV': 'development', + 'process.env.NODE_ENV': JSON.stringify('development'), }), ], }); diff --git a/webpack.prod.js b/webpack.prod.js index 1997776194..eb8403a981 100644 --- a/webpack.prod.js +++ b/webpack.prod.js @@ -6,7 +6,7 @@ module.exports = merge(commonConfig, { mode: 'production', plugins: [ new webpack.DefinePlugin({ - 'process.env.NODE_ENV': 'production', + 'process.env.NODE_ENV': JSON.stringify('production'), }), ], });