Countries with symbols & punctuation in the name are not encoding#1341
Merged
junedkazi merged 1 commit intobigcommerce:masterfrom Sep 5, 2018
hellojakesmith:STRF-5396
Merged
Countries with symbols & punctuation in the name are not encoding#1341junedkazi merged 1 commit intobigcommerce:masterfrom hellojakesmith:STRF-5396
junedkazi merged 1 commit intobigcommerce:masterfrom
hellojakesmith:STRF-5396
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
…rm page in the counrtry dropdown.
junedkazi
approved these changes
Sep 5, 2018
junedkazi
changed the title
Contributor
|
Related to #1292, data is already HTML encoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixing the country name options entities on the account signup form.
This fix is for Cornerstone / Other themes will need to be updated by 3rd parties such as Pixel Union
https://jira.bigcommerce.com/browse/STRF-5396
Countries with symbols & punctuation in the name are not encoding, for example:
"Cote d'Ivoire"updated theme file template/components/common/forms/select.html
-Line 11 Was: <option {{#if selected}} selected {{/if}} value="{{value}}">{{label}}
-Line 11 Now Is: <option {{#if selected}} selected {{/if}} value="{{value}}">{{{label}}}
@bigcommerce/storefront-team