New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-5651: Break product card titles on overflow. #1389

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@Ubersmake
Copy link
Contributor

Ubersmake commented Nov 30, 2018

What?

Changes to the New Products carousel in 2.5.2 changed how many products appeared as the view width became narrower and narrower. Specifically, it would always try to honor the number of columns set for the theme. This means that products with long words get less and less space as the view narrows, and particularly long words start overflowing into adjacent columns.

This change forces words to break if they hit the edge of the column.

This has also been verified to not crash Mobile Safari, which was the reason for #1371 in the first place.

Tickets / Documentation

Screenshots (if appropriate)

Before:

before

After:

after

@bigbot

This comment has been minimized.

Copy link

bigbot commented Nov 30, 2018

@Ubersmake Ubersmake force-pushed the Ubersmake:STRF-5651 branch from 82ccd89 to 185637c Nov 30, 2018

@Ubersmake Ubersmake merged commit 4810a99 into bigcommerce:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ubersmake Ubersmake deleted the Ubersmake:STRF-5651 branch Nov 30, 2018

@EdFromBJCS

This comment has been minimized.

Copy link

EdFromBJCS commented Jan 3, 2019

Is it possible to make this hyphenate word breaks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment