New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable loading of cart on non-cart pages #1401

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@bookernath
Copy link
Contributor

bookernath commented Dec 11, 2018

What?

Disable loading the Cart resource unless we're on the cart page.

This was only used for loading the "quantity in cart", but in #1379 we now do this with a frontend API call.

Turning this off will improve performance.

ping @junedkazi - just opening this for your convenience.

@bigbot

This comment has been minimized.

Copy link

bigbot commented Dec 11, 2018

@bookernath bookernath force-pushed the bookernath:disable-cart branch from a5f3aec to 6ad9107 Dec 13, 2018

@mattolson mattolson merged commit 8dde869 into bigcommerce:master Dec 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bookernath bookernath deleted the bookernath:disable-cart branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment