Explicitly disable autocomplete in password entry input fields.#1465
Merged
Ubersmake merged 1 commit intobigcommerce:masterfrom Mar 19, 2019
Ubersmake:STRF-6102
Merged
Explicitly disable autocomplete in password entry input fields.#1465Ubersmake merged 1 commit intobigcommerce:masterfrom Ubersmake:STRF-6102
Ubersmake merged 1 commit intobigcommerce:masterfrom
Ubersmake:STRF-6102
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
mattolson
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Disables implicit autocomplete on password entry forms for Sign In and when changing passwords when signed in as a customer.
When the autocomplete attribute is not on the form element, autocomplete is implicitly enabled: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
The impetus for this change is increased security for PCI compliance. See https://portswigger.net/kb/issues/00500800_password-field-with-autocomplete-enabled.